[FIX] Addresses bug when tolerance=0
#175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using group-level volumetric atlases, tolerance=0 would raise an error because no samples were assigned (because MNI coords of samples are irregular). This takes floor of the coordinates to match atlas grid.
Issue a warning and continue on, avoiding any errors
rmarkello
changed the title
tolerance=0tolerance=0
Codecov Report
@@ Coverage Diff @@
## main #175 +/- ##
==========================================
- Coverage 96.37% 96.19% -0.18%
==========================================
Files 37 37
Lines 2676 2682 +6
==========================================
+ Hits 2579 2580 +1
- Misses 97 102 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error raised when
tolerance=0where no samples were matched to the provided volumetric atlas. (This was due to changes in #169 that led to using MNI coordinates even for volumetric atlases, such that NO samples are exactly within the volumetric grid. We take the floor of the MNI coordinates now to avoid this error.)Also,
abagen.get_expression_data()now issues a warning (and avoids errors) if any donors have no samples matched to an atlas.