Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Massive reduction in memory usage #130

Merged
merged 6 commits into from
Nov 22, 2019
Merged

[REF] Massive reduction in memory usage #130

merged 6 commits into from
Nov 22, 2019

Conversation

rmarkello
Copy link
Owner

@rmarkello rmarkello commented Nov 22, 2019

Hopefully closes #99

This is an attempt to reduce the memory overhead of get_expression_data. Still a bit slow, but i think these improvements do a lot of legwork and should get us towards where we want to be.

To Do:

  • Check that CircleCI doctests works
  • Remove final Travis tests if CircleCI works

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #130 into master will decrease coverage by 0.19%.
The diff coverage is 94.64%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #130     +/-   ##
=========================================
- Coverage   90.35%   90.15%   -0.2%     
=========================================
  Files          32       32             
  Lines        1991     1961     -30     
=========================================
- Hits         1799     1768     -31     
- Misses        192      193      +1
Impacted Files Coverage Δ
abagen/probes.py 97.11% <100%> (+0.05%) ⬆️
abagen/tests/test_probes.py 100% <100%> (ø) ⬆️
abagen/tests/test_samples.py 100% <100%> (ø) ⬆️
abagen/allen.py 97.97% <75%> (-0.1%) ⬇️
abagen/samples.py 99.04% <96.87%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de700b5...976ec2b. Read the comment docs.

@rmarkello rmarkello merged commit 253b691 into master Nov 22, 2019
@rmarkello rmarkello deleted the memory branch November 22, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory issues with abagen.get_expression_data
1 participant