Solving the bug with max_variance method #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.py when using max_variance method.
While @gifuni was squashing a bug for some version of pandas wherein trying to use `pd.merge` on two `pd.Series` objects failed, he discovered another bug that was plaguing `probe_selection='pc_loading` where a very strange TypeError was raised. I think this minor change (returning df.index[0] and not np.squeeze(df.index)) fixes it! Also, adds an expected blank line
[FIX] Fixes strange TypeError for pc_loading
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 90.36% 90.48% +0.12%
==========================================
Files 32 32
Lines 1993 1987 -6
==========================================
- Hits 1801 1798 -3
+ Misses 192 189 -3
Continue to review full report at Codecov.
|
|
This looks great! Thanks so much for the contribution, @gifuni 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts pandas.Series to DataFrame to resolve merging error in probes.py when using max_variance method.
Solving issue #124