[FIX] specify engine='python' in pandas queries #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specify engine='python' in pandas queries in drop_mismatch function in samples.py files since engine='numexpr' cannot handle NaNs
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 33 33
Lines 1895 1895
=======================================
Hits 1733 1733
Misses 162 162
Continue to review full report at Codecov.
|
|
Looks great! Thanks so much for the quick fix, @VinceBaz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116.
Specify engine='python' in pandas query in drop_mismatch
function (in samples.py file) since engine='numexpr' cannot
handle NaNs and the later is the default option.