[REF] Fixes one-donor bug in get_expression_data() #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When supplying only one donor via the `donor` parameter to get_expression_data() and using the default `probe_selection` method of 'diff_stability' a really cryptic error was raised (see #5). This catches that specific combination and raises a more helpful error. Also adds tests for the errors raised by get_expression_data()
Pull Request Test Coverage Report for Build 323
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 91.32% 91.45% +0.12%
==========================================
Files 33 33
Lines 1891 1895 +4
==========================================
+ Hits 1727 1733 +6
+ Misses 164 162 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5
When supplying only one donor via the
donorparameter toabagen.get_expression_data()and using the defaultprobe_selectionmethod ('diff_stability') a really cryptic error was raised. This catches that specific combination and raises a more helpful error.Also adds tests for the errors raised by
abagen.get_expression_data().