Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Adds ability to calculate dense microarray expression #1

Merged
merged 3 commits into from
Aug 27, 2018

Conversation

gshafiei
Copy link
Contributor

Previously the microarray expression was calculated by matching samples to ROIs in the image. Therefore, the output would have some ROIs with missing expression. The new version has the ability to match all ROIs to closest samples, such that all ROIs will have have at least one assigned sample. Thus, the output microarray expression will be a dense matrix. In order to output the dense microarray expression by matching ROIs to samples, the user has to add "dense=True" as an additional input argument to the function "get_expression_data()".

@rmarkello
Copy link
Owner

Hi @gshafiei! I am so sorry that I haven't commented on this, yet! It's been a very busy month, but that's no excuse for leaving you in the dark like this.

Thank you so much for this contribution! ✨ I will try and do a detailed review of this pull request within the next week and get back to you with any suggestions. In the interim, let me know if there is anything in particular you want me to focus on or that you might be worried about! From a quick scan I can tell you it looks great 🙂 Expect to hear back from me soon with more, though.

@rmarkello
Copy link
Owner

Hi again! I just went through this and it looks great to me. There are a few minor tweaks that I might make at a later date after doing a more thorough check for speed, but I'm going to go ahead and merge this in for now. Thanks so much for this contribution!

@rmarkello rmarkello changed the title [WIP] Added the ability to calculate dense microarray expression by matching ROIs to samples [ENH] Adds ability to calculate dense microarray expression Aug 27, 2018
@rmarkello rmarkello merged commit 0df40cb into rmarkello:master Aug 27, 2018
rmarkello pushed a commit that referenced this pull request Nov 22, 2019
[FIX] Fixes strange TypeError for pc_loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants