-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NanoPi Duo pin mappings added #20
Conversation
The QA build failed - see https://travis-ci.org/rm-hull/OPi.GPIO/jobs/323631901#L563 You should |
Added space CI complained about.
…On Sun, Dec 31, 2017 at 2:37 PM, Richard Hull ***@***.***> wrote:
The QA build failed - see https://travis-ci.org/rm-hull/
OPi.GPIO/jobs/323631901#L563
You should pip install flake8 locally and fix the warnings that flake8 is
complaining about.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADkRZ_4e7xkxw87KUn6gyzXvXCEyclvKks5tF-J-gaJpZM4RP5do>
.
--
Steven P. Goldsmith
|
Looks like the failure in the test is not caused by the code I added. Can you please verify? |
No, not caused by your changes. There are a couple of intermittent failures ... See #19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 All good, just a few tiny observations.
Also, add your name & github handle to CONTRIBUTING.rst as well
nanopi/duo.py
Outdated
@@ -0,0 +1,49 @@ | |||
# -*- coding: utf-8 -*- | |||
# Copyright (c) 2017 Richard Hull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to: # Copyright (c) 2018 Richard Hull & Contributors
nanopi/duo.py
Outdated
# See LICENSE.md for details. | ||
|
||
''' | ||
Created on Dec 31, 2017 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to include created date & author - this can be obtained from git log
, but worthwhile setting docstring header to something like:
Alternative pin mappings for NanoPi DUO board (see http://...)
nanopi/duo.py
Outdated
|
||
Usage: | ||
|
||
import nanopi.duo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the RST code formatting extensions, so this would become:
Usage:
.. code:: python
import nanopi.duo
GPIO.setmode(nanopi.duo.BOARD)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, bringing this up to standards :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 - good stuff, will roll out 0.3.1 shortly with this in
Cool, it will be nice not to use my fork :) |
Feature we discussed in #16