Add support for connecting via Windows named pipes #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hosting Sinopia on Windows' IIS using iisnode, iisnode provides the available port as a Windows named pipe. Node supports these, however the parse_address() function in utils.js does not. A named pipe in Windows has the format: \\.\pipe\PipeName The period specifies the local computer The pipe name string specified by PipeName can include any character other than a backslash, including numbers and special characters. https://msdn.microsoft.com/en-us/library/windows/desktop/aa365783(v=vs.85).aspx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hosting Sinopia on Windows' IIS using iisnode, iisnode provides the available port as a Windows named pipe and not as a port number. Node can open these, however the
parse_address()function inutils.jsdoes not allow them.This PR fixes that.
Named pipes
A named pipe in Windows has the format:
\\.\pipe\PipeNamePipeNamecan include any characterother than a backslash, including numbers and special characters.
From: https://msdn.microsoft.com/en-us/library/windows/desktop/aa365783(v=vs.85).aspx
How to use it in iisnode
It can be used in iisnode by creating a project,
npm install sinopiaand then createindex.js:Configure iisnode to use
index.jsas start file.