drop present? #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ephekt I am happy to have you work on this fork. It could use a little more cleanup, which I am planning to get to, but I'm all for help if you're up to it. |
|
We're going to roll your fork into production so I am sure it's going to On Tue, Oct 22, 2013 at 3:17 PM, Randy Burkes [email protected]:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/Users/mrose/.rbenv/versions/1.9.3-p327/lib/ruby/gems/1.9.1/bundler/gems/roo-60b0a57da1b7/lib/roo/excelx.rb:554:in 'cells_for_row_element': undefined method 'present?' for #<Nokogiri::XML::Element:0x007fdbb1db58c8> (NoMethodError)The gem was failing when parsing XLSX due to the present? not being a valid method on the Nokogiri::XML::Element object.
Dropped present? and things worked smoothly. Wish your fork would get merged into roo master!