Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context Menu doesn't show up if only one log file is opened #189

Closed
rladstaetter opened this issue Dec 23, 2023 · 1 comment · Fixed by #196
Closed

Context Menu doesn't show up if only one log file is opened #189

rladstaetter opened this issue Dec 23, 2023 · 1 comment · Fixed by #196
Labels
bug Something isn't working
Milestone
24.2.0

Comments

@rladstaetter
Copy link
Owner

If you open only one log file, the context menu won't be shown.

Expected behavior is to show the context menu, with following entries:

  • Close
  • Show Log in Finder
@rladstaetter rladstaetter added this to the 24.2.0 milestone Dec 23, 2023
@rladstaetter rladstaetter added the bug Something isn't working label Dec 23, 2023
@rladstaetter
Copy link
Owner Author

rladstaetter commented Dec 27, 2023 •
edited
Loading

Following changes were made:

  • if only one file is opened, show context menu with entries Close and Show Log in Finder
  • if more than one log file is opened, show all context menu entries (depending on the position)

the context menu has to be updated depending on the number and position of the tab.

189-context-menu-changes

rladstaetter added a commit that referenced this issue Dec 27, 2023
@rladstaetter
#189: fixes context menu for LogFileTab
269f988
@rladstaetter rladstaetter linked a pull request Dec 27, 2023 that will close this issue
#189: fixes context menu for LogFileTab #196
Merged
rladstaetter added a commit that referenced this issue Dec 27, 2023
@rladstaetter
Merge pull request #196 from rladstaetter/189-context-menu-doesnt-sho…
4dd5abc 
…w-up-if-only-one-log-file-is-opened

#189: fixes context menu for LogFileTab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
24.2.0
Development

Successfully merging a pull request may close this issue.

#189: fixes context menu for LogFileTab rladstaetter/LogoRRR
1 participant
@rladstaetter