Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve configuration de/serialisation #105

Closed
rladstaetter opened this issue Oct 16, 2022 · 0 comments · Fixed by #138
Closed

Improve configuration de/serialisation #105

rladstaetter opened this issue Oct 16, 2022 · 0 comments · Fixed by #138
Assignees
@rladstaetter
Milestone
23.2.1

Comments

@rladstaetter
Copy link
Owner

For writing/reading the configuration file the code could be improved. For example, in the filter class, there should be an encoder for javafx.scene.paint.Color.
@rladstaetter rladstaetter self-assigned this Oct 22, 2022
@rladstaetter rladstaetter added this to the 23.1.0 milestone Oct 22, 2022
@rladstaetter rladstaetter modified the milestones: 23.1.0, 23.2.0 Jan 15, 2023
rladstaetter added a commit that referenced this issue Feb 26, 2023
@rladstaetter
#105: adds custom ConfigReader and ConfigWriter for Filter
5162e75 
Introducing custom ConfigReader and ConfigWriter for Filter, now enables the usage of javafx.scene.paint.Color in the Filter constructor, resulting in a more streamlined implementation.
@rladstaetter rladstaetter linked a pull request Feb 26, 2023 that will close this issue
105 improve configuration deserialisation #138
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rladstaetter rladstaetter

Labels
None yet
Projects
None yet
Milestone
23.2.1
Development

Successfully merging a pull request may close this issue.

105 improve configuration deserialisation rladstaetter/LogoRRR
1 participant
@rladstaetter