#212: introduces native call to open an external browser on MacOsX

app/src/main/java/app/logorrr/OsxBridge.java

@@ -4,9 +4,25 @@
  * Provides interface methods for native code
  */
 public class OsxBridge {
-
+    /**
+     * register a file in the macosx permission system
+     *
+     * @param path absolute path to the file
+     */
     public static native void registerPath(String path);
 
+    /**
+     * release a path (if the path is no longer used for example)
+     *
+     * @param path absolute path to the file
+     */
     public static native void releasePath(String path);
 
+    /**
+     * open an url via the native browser
+     *
+     * @param url the url to open, for example https://www.logorrr.app/
+     */
+    public static native void openUrl(String url);
+
 }

app/src/main/scala/app/logorrr/services/hostservices/NativeHostServices.scala

@@ -1,9 +1,19 @@
 package app.logorrr.services.hostservices
 
+import app.logorrr.OsxBridge
+import app.logorrr.util.OsUtil
 import javafx.application.HostServices
 
 class NativeHostServices(hostServices: => HostServices) extends LogoRRRHostServices {
 
-  override def showDocument(url: String): Unit = hostServices.showDocument(url)
+  override def showDocument(url: String): Unit = {
+    // hostServices.showDocument doesn't work with Entitlements / Gatekeeper
+    // delegate to native method
+    if (OsUtil.isMac) {
+      OsxBridge.openUrl(url)
+    } else {
+      hostServices.showDocument(url)
+    }
+  }
 
 }

dist/dist-osx/installer-osx/src/main/installer/LogoRRR.entitlements.xml

@@ -23,5 +23,8 @@
         <!-- to be able to access files see https://developer.apple.com/documentation/professional_video_applications/fcpxml_reference/asset/media-rep/bookmark/enabling_security-scoped_bookmark_and_url_access?language=swift -->
         <key>com.apple.security.files.bookmarks.app-scope</key>
         <true/>
+        <!-- to access network (open urls) -->
+        <key>com.apple.security.network.client</key>
+        <true/>
     </dict>
 </plist>

native/native-osx/src/main/c/LogoRRRSwift.swift

@@ -1,4 +1,15 @@
 import Foundation
+import Cocoa
+
+@_cdecl("openUrl")
+public func openUrl(path : UnsafePointer<Int8>) {
+    if let urlString = String(validatingUTF8: path) {
+        if let url = URL(string: urlString) {
+           NSWorkspace.shared.open(url)
+        }
+    }
+}
+
 
 @_cdecl("releasePath")
 public func releasePath(path: UnsafePointer<Int8>) {

native/native-osx/src/main/c/OsxBridge.c

@@ -5,7 +5,7 @@
 
 JNIEXPORT void JNICALL Java_app_logorrr_OsxBridge_registerPath(JNIEnv *env, jobject obj, jstring path) {
     const char *pathChars = (*env)->GetStringUTFChars(env, path, NULL);
-     if (pathChars != NULL) {
+    if (pathChars != NULL) {
          // Call the Swift function from C
          registerPath(pathChars);
 
@@ -14,11 +14,19 @@ JNIEXPORT void JNICALL Java_app_logorrr_OsxBridge_registerPath(JNIEnv *env, jobj
      }
 }
 
-
 JNIEXPORT void JNICALL Java_app_logorrr_OsxBridge_releasePath(JNIEnv *env, jobject obj, jstring path) {
     const char *pathChars = (*env)->GetStringUTFChars(env, path, NULL);
-     if (pathChars != NULL) {
+    if (pathChars != NULL) {
          releasePath(pathChars);
          (*env)->ReleaseStringUTFChars(env, path, pathChars);
-     }
+    }
 }
+
+JNIEXPORT void JNICALL Java_app_logorrr_OsxBridge_openUrl(JNIEnv *env, jobject obj, jstring path) {
+    const char *urlChars = (*env)->GetStringUTFChars(env, path, NULL);
+    if (urlChars != NULL) {
+        openUrl(urlChars);
+        (*env)->ReleaseStringUTFChars(env, path, urlChars);
+    }
+}
+

native/native-osx/src/main/c/app_logorrr_OsxBridge_swift.h

@@ -1,2 +1,3 @@
 void registerPath(const char* path);
-void releasePath(const char* path);
+void releasePath(const char* path);
+void openUrl(const char* url);