#208: adds test to check visibility on startup

app-tests/src/test/scala/app/logorrr/usecases/SingleFileApplicationTest.scala

@@ -17,7 +17,7 @@ class SingleFileApplicationTest(val path: Path)
     with CanStartApplication
     with CanOpenFile {
 
-  val services: LogoRRRServices = LogoRRRServices(Settings.Default
+  final def services: LogoRRRServices = LogoRRRServices(Settings.Default
     , new MockHostServices
     , new OpenSingleFileService(Option(path))
     , isUnderTest = true)

app-tests/src/test/scala/app/logorrr/usecases/chunkview/SimpleBlockSizeTest.scala → app-tests/src/test/scala/app/logorrr/usecases/blockview/SimpleBlockSizeTest.scala

@@ -1,11 +1,8 @@
-package app.logorrr.usecases.chunkview
+package app.logorrr.usecases.blockview
 
 import app.logorrr.TestFiles
-import app.logorrr.conf.{LogoRRRGlobals, Settings, StageSettings}
+import app.logorrr.conf.LogoRRRGlobals
 import app.logorrr.io.FileId
-import app.logorrr.services.LogoRRRServices
-import app.logorrr.services.fileservices.OpenSingleFileService
-import app.logorrr.services.hostservices.MockHostServices
 import app.logorrr.usecases.SingleFileApplicationTest
 import app.logorrr.views.ops.{DecreaseBlockSizeButton, IncreaseBlockSizeButton}
 import app.logorrr.views.search.OpsToolBar
@@ -16,11 +13,6 @@ import org.junit.jupiter.api.Test
  */
 class SimpleBlockSizeTest extends SingleFileApplicationTest(TestFiles.simpleLog0) {
 
-  override val services: LogoRRRServices = LogoRRRServices(Settings.Default.copy(stageSettings = StageSettings(100, 100, 1200, 600))
-    , new MockHostServices
-    , new OpenSingleFileService(Option(path))
-    , isUnderTest = true)
-
   @Test def search(): Unit = {
     openFile(path)
     val fileId = FileId(path)

app-tests/src/test/scala/app/logorrr/usecases/search/SimpleSearchTest.scala

@@ -21,6 +21,6 @@ class SimpleSearchTest extends SingleFileApplicationTest(TestFiles.simpleLog0) {
 
   private def searchFor(needle: String) = {
     clickOn(SearchTextField.uiNode(FileId(path)).ref).write(needle)
-    clickOn(SearchButton.id(FileId(path)).ref)
+    clickOn(SearchButton.uiNode(FileId(path)).ref)
   }
 }

app-tests/src/test/scala/app/logorrr/usecases/startup/VisibilityOnStartupTest.scala

@@ -0,0 +1,46 @@
+package app.logorrr.usecases.startup
+
+import app.logorrr.TestFiles
+import app.logorrr.io.FileId
+import app.logorrr.usecases.SingleFileApplicationTest
+import app.logorrr.views.autoscroll.AutoScrollCheckBox
+import app.logorrr.views.ops.{ClearLogButton, CopyLogButton, DecreaseBlockSizeButton, IncreaseBlockSizeButton}
+import app.logorrr.views.search.{SearchButton, SearchTextField}
+import app.logorrr.views.text.toolbaractions.{DecreaseTextSizeButton, IncreaseTextSizeButton}
+import org.junit.jupiter.api.Test
+import org.testfx.api.FxAssert
+import org.testfx.matcher.base.NodeMatchers
+
+/**
+ * Tests if all major UI elements are visible with default settings on first startup
+ */
+class VisibilityOnStartupTest extends SingleFileApplicationTest(TestFiles.simpleLog0) {
+
+  @Test def checkIfAllMajorUIElementsAreVisibleWithDefaultSettings(): Unit = {
+    openFile(path)
+    val fileId = FileId(path)
+    //wait until UI is ready
+
+    val elements = Seq(
+      SearchTextField.uiNode(fileId)
+      , SearchButton.uiNode(fileId)
+      , DecreaseBlockSizeButton.uiNode(fileId)
+      , IncreaseBlockSizeButton.uiNode(fileId)
+      , DecreaseTextSizeButton.uiNode(fileId)
+      , IncreaseTextSizeButton.uiNode(fileId)
+      , AutoScrollCheckBox.uiNode(fileId)
+      , ClearLogButton.uiNode(fileId)
+      , CopyLogButton.uiNode(fileId)
+    )
+
+    // check all elements
+    for (uiElement <- elements) {
+      waitForVisibility(uiElement)
+      FxAssert.verifyThat(lookup(uiElement.ref), NodeMatchers.isVisible)
+    }
+  }
+
+
+}
+
+

app-tests/src/test/scala/app/logorrr/usecases/textview/SimpleTextSizeTest.scala

@@ -1,11 +1,8 @@
 package app.logorrr.usecases.textview
 
 import app.logorrr.TestFiles
-import app.logorrr.conf.{LogoRRRGlobals, Settings, StageSettings}
+import app.logorrr.conf.LogoRRRGlobals
 import app.logorrr.io.FileId
-import app.logorrr.services.LogoRRRServices
-import app.logorrr.services.fileservices.OpenSingleFileService
-import app.logorrr.services.hostservices.MockHostServices
 import app.logorrr.usecases.SingleFileApplicationTest
 import app.logorrr.views.search.OpsToolBar
 import app.logorrr.views.text.toolbaractions.{DecreaseTextSizeButton, IncreaseTextSizeButton}
@@ -16,11 +13,6 @@ import org.junit.jupiter.api.Test
  */
 class SimpleTextSizeTest extends SingleFileApplicationTest(TestFiles.simpleLog0) {
 
-  override val services: LogoRRRServices = LogoRRRServices(Settings.Default.copy(stageSettings = StageSettings(100, 100, 1200, 600))
-    , new MockHostServices
-    , new OpenSingleFileService(Option(path))
-    , isUnderTest = true)
-
   @Test def search(): Unit = {
     openFile(path)
     val fileId = FileId(path)

app/src/main/scala/app/logorrr/conf/StageSettings.scala

@@ -1,7 +1,8 @@
 package app.logorrr.conf
 
-import pureconfig.{ConfigReader, ConfigWriter}
+import javafx.geometry.Rectangle2D
 import pureconfig.generic.semiauto.{deriveReader, deriveWriter}
+import pureconfig.{ConfigReader, ConfigWriter}
 
 
 
@@ -10,13 +11,16 @@ object StageSettings {
   implicit val reader: ConfigReader[StageSettings] = deriveReader[StageSettings]
   implicit val writer: ConfigWriter[StageSettings] = deriveWriter[StageSettings]
 
+  def apply(rectangle2D: Rectangle2D): StageSettings = {
+    StageSettings(rectangle2D.getMinX, rectangle2D.getMinY, rectangle2D.getWidth.toInt, rectangle2D.getHeight.toInt)
+  }
 
 }
 
 /**
- * @param x upper left x cooordinate for Logorrr
- * @param y upper left y cooordinate for Logorrr
- * @param width width of stage
+ * @param x      upper left x cooordinate for Logorrr
+ * @param y      upper left y cooordinate for Logorrr
+ * @param width  width of stage
  * @param height height of stage
  */
 case class StageSettings(x: Double

app/src/main/scala/app/logorrr/model/HasFileId.scala

@@ -5,4 +5,5 @@ import app.logorrr.io.FileId
 trait HasFileId {
 
   def fileId: FileId
+
 }

app/src/main/scala/app/logorrr/views/UiNodes.scala

@@ -1,5 +1,16 @@
 package app.logorrr.views
 
+import app.logorrr.io.FileId
+import app.logorrr.util.HashUtil
+
+object UiNode {
+
+  def apply(fileId: FileId, clazz: Class[_]): UiNode = {
+    UiNode(clazz.getSimpleName + "-" + HashUtil.md5Sum(fileId))
+  }
+
+}
+
 case class UiNode(value: String) {
 
   lazy val ref: String = "#" + value
@@ -31,5 +42,4 @@ object UiNodes {
   val LogFileHeaderTabCloseButton = ".tab-container > .tab-close-button"
 
 
-
 }

app/src/main/scala/app/logorrr/views/autoscroll/AutoScrollCheckBox.scala

@@ -8,13 +8,13 @@ import javafx.scene.control.{CheckBox, Tooltip}
 
 object AutoScrollCheckBox extends UiNodeAware {
 
-  override def uiNode(id: FileId): UiNode = UiNode("autoscrollcheckbox-" + id)
+  override def uiNode(id: FileId): UiNode = UiNode(id, classOf[AutoScrollCheckBox])
+
 }
 
 class AutoScrollCheckBox(val fileId: FileId) extends CheckBox with HasFileId {
-  setId(AutoScrollCheckBox.uiNode(fileId).ref)
+  setId(AutoScrollCheckBox.uiNode(fileId).value)
   setTooltip(new Tooltip("autoscroll"))
   selectedProperty().bindBidirectional(LogoRRRGlobals.getLogFileSettings(fileId).autoScrollActiveProperty)
 
-
 }

app/src/main/scala/app/logorrr/views/logfiletab/LogFileTab.scala

@@ -5,10 +5,10 @@ import app.logorrr.conf.mut.MutLogFileSettings
 import app.logorrr.io.FileId
 import app.logorrr.model.LogEntry
 import app.logorrr.util._
-import app.logorrr.views.{LogoRRRAccelerators, UiNode, UiNodeAware}
 import app.logorrr.views.autoscroll.LogTailer
 import app.logorrr.views.logfiletab.actions._
 import app.logorrr.views.search.Fltr
+import app.logorrr.views.{LogoRRRAccelerators, UiNode, UiNodeAware}
 import javafx.beans.binding.Bindings
 import javafx.collections.{ListChangeListener, ObservableList}
 import javafx.event.Event
@@ -52,7 +52,7 @@ object LogFileTab extends UiNodeAware {
       , entries)
   }
 
-  def uiNode(fileId: FileId): UiNode = UiNode("logfiletab-" + HashUtil.md5Sum(fileId))
+  override def uiNode(id: FileId): UiNode = UiNode(id, classOf[LogFileTab])
 
 }
 

app/src/main/scala/app/logorrr/views/ops/ClearLogButton.scala

@@ -2,7 +2,6 @@ package app.logorrr.views.ops
 
 import app.logorrr.io.FileId
 import app.logorrr.model.LogEntry
-import app.logorrr.util.HashUtil
 import app.logorrr.views.{UiNode, UiNodeAware}
 import javafx.collections.ObservableList
 import javafx.scene.control.{Button, Tooltip}
@@ -11,7 +10,7 @@ import org.kordamp.ikonli.javafx.FontIcon
 
 object ClearLogButton extends UiNodeAware {
 
-  def uiNode(id: FileId): UiNode = UiNode("clearlogbutton-" + HashUtil.md5Sum(id))
+  def uiNode(id: FileId): UiNode = UiNode(id, classOf[ClearLogButton])
 
 }
 

app/src/main/scala/app/logorrr/views/ops/CopyLogButton.scala

@@ -2,7 +2,6 @@ package app.logorrr.views.ops
 
 import app.logorrr.io.FileId
 import app.logorrr.model.LogEntry
-import app.logorrr.util.HashUtil
 import app.logorrr.views.{UiNode, UiNodeAware}
 import javafx.animation.AnimationTimer
 import javafx.collections.ObservableList
@@ -15,7 +14,7 @@ import scala.collection.mutable.ListBuffer
 
 object CopyLogButton extends UiNodeAware {
 
-  def uiNode(id: FileId): UiNode = UiNode("copylogbutton-" + HashUtil.md5Sum(id))
+  def uiNode(id: FileId): UiNode = UiNode(id, classOf[CopyLogButton])
 
 }
 

app/src/main/scala/app/logorrr/views/ops/DecreaseBlockSizeButton.scala

@@ -1,7 +1,6 @@
 package app.logorrr.views.ops
 
 import app.logorrr.io.FileId
-import app.logorrr.util.HashUtil
 import app.logorrr.views.block.{BlockConstants, HasBlockSizeProperty}
 import app.logorrr.views.search.OpsToolBar
 import app.logorrr.views.{UiNode, UiNodeAware}
@@ -12,7 +11,7 @@ object DecreaseBlockSizeButton extends UiNodeAware {
   /** size of icon to decrease block size */
   val Size = 8
 
-  override def uiNode(id: FileId): UiNode = UiNode("decreaseblocksizebutton-" + HashUtil.md5Sum(id))
+  override def uiNode(id: FileId): UiNode = UiNode(id, classOf[DecreaseBlockSizeButton])
 }
 
 class DecreaseBlockSizeButton(id: FileId, val blockSizeProperty: SimpleIntegerProperty) extends

app/src/main/scala/app/logorrr/views/ops/IncreaseBlockSizeButton.scala

@@ -1,7 +1,6 @@
 package app.logorrr.views.ops
 
 import app.logorrr.io.FileId
-import app.logorrr.util.HashUtil
 import app.logorrr.views.block.HasBlockSizeProperty
 import app.logorrr.views.search.OpsToolBar
 import app.logorrr.views.{UiNode, UiNodeAware}
@@ -13,7 +12,7 @@ object IncreaseBlockSizeButton extends UiNodeAware {
   /** size of icon to increase block size */
   val Size = 16
 
-  override def uiNode(id: FileId): UiNode = UiNode("increaseblocksizebutton-" + HashUtil.md5Sum(id))
+  override def uiNode(id: FileId): UiNode = UiNode(id, classOf[IncreaseBlockSizeButton])
 }
 
 class IncreaseBlockSizeButton(id: FileId, val blockSizeProperty: SimpleIntegerProperty)

app/src/main/scala/app/logorrr/views/search/SearchActivateRegexToggleButton.scala

@@ -1,14 +1,14 @@
 package app.logorrr.views.search
 
 import app.logorrr.io.FileId
-import app.logorrr.util.{HashUtil, LogoRRRFonts, OsUtil}
+import app.logorrr.util.{LogoRRRFonts, OsUtil}
 import app.logorrr.views.{UiNode, UiNodeAware}
 import javafx.scene.control.{Label, ToggleButton, Tooltip}
 import javafx.scene.paint.Color
 
 object SearchActivateRegexToggleButton extends UiNodeAware {
 
-  override def uiNode(id: FileId): UiNode = UiNode("searchactivateregextogglebutton-" + HashUtil.md5Sum(id))
+  override def uiNode(id: FileId): UiNode = UiNode(id, classOf[SearchActivateRegexToggleButton])
 
 }
 

app/src/main/scala/app/logorrr/views/search/SearchButton.scala

@@ -2,15 +2,15 @@ package app.logorrr.views.search
 
 
 import app.logorrr.io.FileId
-import app.logorrr.util.{ColorUtil, HashUtil}
-import app.logorrr.views.UiNode
+import app.logorrr.util.ColorUtil
+import app.logorrr.views.{UiNode, UiNodeAware}
 import javafx.scene.control.{Button, Tooltip}
 import org.kordamp.ikonli.fontawesome5.FontAwesomeSolid
 import org.kordamp.ikonli.javafx.FontIcon
 
-object SearchButton {
+object SearchButton extends UiNodeAware {
 
-  def id(id: FileId): UiNode = UiNode("searchbutton-" + HashUtil.md5Sum(id))
+  override def uiNode(id: FileId): UiNode = UiNode(id, classOf[SearchButton])
 
 }
 
@@ -20,7 +20,7 @@ class SearchButton(fileId: FileId
                    , colorPicker: SearchColorPicker
                    , addFilterFn: Filter => Unit) extends Button {
 
-  setId(SearchButton.id(fileId).value)
+  setId(SearchButton.uiNode(fileId).value)
   setGraphic(new FontIcon(FontAwesomeSolid.SEARCH))
   setTooltip(new Tooltip("search"))
   setMaxWidth(40)

app/src/main/scala/app/logorrr/views/search/SearchColorPicker.scala

@@ -1,13 +1,13 @@
 package app.logorrr.views.search
 
 import app.logorrr.io.FileId
-import app.logorrr.util.{ColorUtil, HashUtil}
+import app.logorrr.util.ColorUtil
 import app.logorrr.views.{UiNode, UiNodeAware}
 import javafx.scene.control.{ColorPicker, Tooltip}
 
 object SearchColorPicker extends UiNodeAware {
 
-  override def uiNode(id: FileId): UiNode = UiNode("searchcolorpicker-" + HashUtil.md5Sum(id))
+  override def uiNode(id: FileId): UiNode = UiNode(id, classOf[SearchColorPicker])
 }
 
 class SearchColorPicker(id : FileId) extends ColorPicker {

app/src/main/scala/app/logorrr/views/search/SearchTextField.scala

@@ -1,7 +1,7 @@
 package app.logorrr.views.search
 
 import app.logorrr.io.FileId
-import app.logorrr.util.{HashUtil, OsUtil}
+import app.logorrr.util.OsUtil
 import app.logorrr.views.{UiNode, UiNodeAware}
 import javafx.beans.binding.StringBinding
 import javafx.scene.control.{TextField, Tooltip}
@@ -10,7 +10,7 @@ import javafx.scene.control.{TextField, Tooltip}
 
 object SearchTextField extends UiNodeAware {
 
-  def uiNode(id: FileId): UiNode = UiNode("searchtextfield-" + HashUtil.md5Sum(id))
+  override def uiNode(id: FileId): UiNode = UiNode(id, classOf[SearchTextField])
 
 }
 

app/src/main/scala/app/logorrr/views/text/LogTextView.scala

@@ -1,20 +1,28 @@
 package app.logorrr.views.text
 
 import app.logorrr.conf.mut.MutLogFileSettings
+import app.logorrr.io.FileId
 import app.logorrr.model.LogEntry
 import app.logorrr.util.{CanLog, JfxUtils}
 import app.logorrr.views.text.contextactions.{IgnoreAboveMenuItem, IgnoreBelowMenuItem}
+import app.logorrr.views.{UiNode, UiNodeAware}
 import javafx.collections.transformation.FilteredList
 import javafx.scene.control._
 
 import scala.jdk.CollectionConverters._
 
+object LogTextView extends UiNodeAware {
+
+  override def uiNode(id: FileId): UiNode = UiNode(id, classOf[LogTextView])
+
+}
+
 class LogTextView(mutLogFileSettings: MutLogFileSettings
                   , filteredList: FilteredList[LogEntry])
   extends ListView[LogEntry]
     with CanLog {
 
-  setId("")
+  setId(LogTextView.uiNode(mutLogFileSettings.getFileId).value)
 
   def scrollToItem(item: LogEntry): Unit = {
     getSelectionModel.select(item)