-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing quote #356
Add missing quote #356
Conversation
🎉 The preview is built! Check it out 👀 |
@SoyAndrea The missing quote made the build fail. GitHub highlights the line in read after the missing quote, so in the future we might avoid part of the misformating by looking at the file in GitHub, see screenshot below: Now, dealing with JSON/YAML means we'll often fight missing commas or quotes, that's our fate 😂 |
Also, we should no longer merge PR if the checks are red as the checks are stable now... Should we look into adding a branch protection rule? |
Thanks @maelle! You know I had to read it several times because I couldn't see the missing quote. 😂 Now that I've checked it and it's OK, can I accept the merge and fix this commit? |
@drmowinckels Mo, in this PR can we change the mail of the chapter that was before, with the comment you left here? |
@SoyAndrea we could, but I dont want to change the email right now, as leadership are looking into why the chapter prefer using the gmail over rladies mail. If this is the best point of contact right now, we should keep the email as is and rather change it later if we can. So I think it is ok to merge when you can @SoyAndrea :) Thank you @maelle for the helP! |
@maelle do you have the opportunity to look into the branch protection rules and make a suggestion? |
I opened #357 as yes I'd like to help with this but not this week so let's not make the idea a blocker 😸 |
No description provided.