Issue31 mock tests #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use with_mock to override GET() * create a testdata folder for storing mocks * improve tests for find_groups.R * add a test for internals.R Part of Issue #31
Part of Issue #31
* get_events now tests the get_events call * added TODO's for future tests based on logical branches * find_groups now runs with and without optional params Part of Issue #31
|
Just added a bunch of folks to review, but I don't need all of them ;) |
|
Found a couple lines with debug code, I'll push an update to remove it. |
Part of Issue #31
|
just double checked and this is up to date! let me know what next steps you all recommend. |
|
It looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #31