Fix #111 by using next_url only for pagination handling #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregSutcliffe
force-pushed
the
pagination
branch
from
296b095 to
e01ad5e
Compare
|
Tests added as per discussion in #112 |
|
Ugh, tests have failed. They pass for me locally with |
GregSutcliffe
force-pushed
the
pagination
branch
from
e01ad5e to
9e1cd27
Compare
|
That's got it. Forgot part of a commit from my local branch :) |
|
@ledell would you have time to have a look? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion, I removed the initial call to
meetup_callas it appeared to be duplicating results whereoffsetn == 2.Since we now don't actually use
iin the API calls (it's all handled bynext_page) I've also taken the opportunity to make the code more readable:offfsetnis renamed tomax_pages, and we start the loop from 2 so we're clear it's all the subsequent pages.Also, I snuck in an extra commit for default values on
organizerbecause I keep tripping over that - but I can break it out to another PR if you wish.I'll take a look at the tests now, but I wanted to get this posted while it was fresh in my head.