Feature critical demand #166

adnanalakori · 2021-12-01T12:39:05Z

Just re-define constants..
Fixes #165

By the way: once I made a PR, it shows with a new number #166 -> should be a way to keep this PR within the previous one #165?

Release Offgridders v.4.4

Prepare release V4.5

Release v4.6

Release/v4.6.1

…tical", "demand_dc_critical" to the excel input file

…e_demand_dc_non_critical and title_demand_dc_critical in the excel, and define constants in

…TICAL and DEMAND_PROFILE_DC_CRITICAL

Co-authored-by: smartie2076 <[email protected]>

adnanalakori

I am not sure about the last commit!

smartie2076 · 2021-12-02T12:39:43Z

Just re-define constants.. Fixes #165

Hi @adnanalakori! I am not sure from the title and text what you are planning in this PR, and will have to check this from the code. You should try to use a title that is different from #165, that directly tells me what you do.

Also, "fix"/"close" are github-specific words that imply an action that github will take. They are used to close issues, ie. to adress and solve an issue. Used here, I am not sure what it will do with the other PR.

By the way: once I made a PR, it shows with a new number #166 -> should be a way to keep this PR within the previous one #165?

I think you created a new PR, because you pushed to a different branch name. The other branch is feature_critical_demand and not feature_critical_demand_. If you want to continue working on #165 you need to push onto feature_critical_demand!

Should I then even look at this?

smartie2076

cbc.exe and coin-license.txt should not be pushed to the repo. I am not clear what you are planning to do...

smartie2076 · 2021-12-02T12:42:20Z

src/constants.py

+DEMAND_AC = "demand_ac_non_critical"
+DEMAND_AC = "demand_ac_critical"
+DEMAND_DC = "demand_dc_non_critical"
+DEMAND_DC = "demand_dc_critical"


You now have redefined DEMAND_AC and DEMAND_DC directly after you defined it. Variables have to be unique.

Ok, got it, w'll correct it -> hoppfully it runs w/o errors

Will run without errors, but not nesessarily run as intended :D

smartie2076 · 2021-12-02T12:42:52Z

src/constants.py

+TITLE_DEMAND_AC = "title_demand_ac_non_critical"
+TITLE_DEMAND_AC = "title_demand_ac_critical"
+TITLE_DEMAND_DC = "title_demand_dc_non_critical"
+TITLE_DEMAND_DC = "title_demand_dc_critical"


TITLE_DEMAND_AC and TITLE_DEMAND_DC are defined twice, this does not work.

cbc.exe and coin-license.txt should not be pushed to the repo. I am not clear what you are planning to do...

I don't know how cbc.exe was pushed, weird...! I just received this error message "Error: No executable found for solver 'cbc'", then I copied it again to offgridders folder and re-run it.

Do you know this always why this happening ?

Yeah, when you commit, by default all changes and added files will be added to your commit. You have to unselect the file from the upper box (the one over the commit message box):

smartie2076 · 2021-12-02T12:43:35Z

src/G2a_oemof_busses_and_componets.py

@@ -709,7 +709,7 @@ def distribution_grid_ac(
    return distribution


-def demand_ac(micro_grid_system, bus_electricity_ac, demand_profile):
+def demand_ac(micro_grid_system, bus_electricity_ac, demand_profile, demand_name):


What are you planning to do with demand_name?

Now I understand it is correct.

smartie2076 · 2021-12-02T12:44:03Z

src/G2a_oemof_busses_and_componets.py

@@ -721,10 +721,11 @@ def demand_ac(micro_grid_system, bus_electricity_ac, demand_profile):
    )

    micro_grid_system.add(sink_demand_ac)
+    demand_name.add(sink_demand_ac)


I do not understand what you use demand_name for, and why you use add().

I was just planning just to merge the functions generate.demand_ac and generate.demand_dc to function generate.demand, but not sure about the structure of this function below:

offgridders/src/G2a_oemof_busses_and_componets.py

Line 704 in a8fa6f1

def demand_ac(micro_grid_system, bus_electricity_ac, demand_profile):

Also, just trying to reach your goal mentioned in the #162, that the new demand shall be like that :

sink_demand_ac_critical = generate.demand( micro_grid_system, bus_electricity_ac, experiment[DEMAND_PROFILE_AC_CRITICAL], demand_name=DEMAND_AC_CRITICAL )

I was just planning just to merge the functions generate.demand_ac and generate.demand_dc to function generate.demand, but not sure about the structure of this function below

Yeah, that is a good idea! You will have to change

def demand(micro_grid_system, bus_electricity_ac, demand_profile, demand_name):

Also, just trying to reach your goal mentioned in the #162, that the new demand shall be like that :
[Code]

This is correct :)

adnanalakori · 2021-12-02T13:25:55Z

Should I then even look at this?

Hi @smartie2076, sorry it just a mistake that a slash _ was added to the feature_critical_demand, then a new PR has been opened, I was wondering of that :-) Could we delate this PR completely and keep us in the #165 ?

smartie2076 and others added 15 commits July 9, 2020 21:17

Merge pull request #98 from rl-institut/release/v.4.3

a6e31d7

Release Offgridders v.4.4

Update CHANGELOG.md

bae4acf

Merge branch 'master' into release/v4.5

280b5b3

Merge pull request #120 from rl-institut/release/v4.5

4a63104

Prepare release V4.5

Update CHANGELOG.md

d7b7f56

Merge branch 'master' into release/v4.6

e2c2980

Merge pull request #124 from rl-institut/release/v4.6

2cb83a7

Release v4.6

Merge branch 'master' into release/v4.6.1

3e9a719

Merge pull request #147 from rl-institut/release/v4.6.1

fcc92cf

Release/v4.6.1

Add "demand_ac_non_critical","demand_ac_critical", "demand_dc_non_cri…

172594d

…tical", "demand_dc_critical" to the excel input file

Implement title_demand_ac_non_critical, title_demand_ac_critical,titl…

8378d73

…e_demand_dc_non_critical and title_demand_dc_critical in the excel, and define constants in

Check that timeseries was parsed correctly, add DEMAND_PROFILE_AC_CRI…

503403c

…TICAL and DEMAND_PROFILE_DC_CRITICAL

Update inputs/timeseries/test_site.csv

822097a

Co-authored-by: smartie2076 <[email protected]>

Define constants demand_ac_non_critical, etc

b9e8da2

Implement demand_ac_non_critical etc as constants

f61f428

adnanalakori requested a review from smartie2076 December 1, 2021 12:43

Add "generate_demand" for new critical demands

8a3f998

adnanalakori commented Dec 1, 2021

View reviewed changes

smartie2076 requested changes Dec 2, 2021

View reviewed changes

adnanalakori closed this Dec 6, 2021

adnanalakori deleted the feature_critical_demand_ branch January 13, 2022 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature critical demand #166

Feature critical demand #166

adnanalakori commented Dec 1, 2021 •

edited

Loading

adnanalakori left a comment •

edited

Loading

smartie2076 commented Dec 2, 2021

smartie2076 left a comment

smartie2076 Dec 2, 2021

adnanalakori Dec 2, 2021 •

edited

Loading

smartie2076 Dec 8, 2021 •

edited

Loading

smartie2076 Dec 2, 2021

adnanalakori Dec 3, 2021 •

edited

Loading

smartie2076 Dec 8, 2021

smartie2076 Dec 2, 2021

smartie2076 Dec 8, 2021

smartie2076 Dec 2, 2021

adnanalakori Dec 2, 2021 •

edited by smartie2076

Loading

smartie2076 Dec 8, 2021 •

edited

Loading

adnanalakori commented Dec 2, 2021 •

edited

Loading

Feature critical demand #166

Feature critical demand #166

Conversation

adnanalakori commented Dec 1, 2021 • edited Loading

adnanalakori left a comment • edited Loading

Choose a reason for hiding this comment

smartie2076 commented Dec 2, 2021

smartie2076 left a comment

Choose a reason for hiding this comment

smartie2076 Dec 2, 2021

Choose a reason for hiding this comment

adnanalakori Dec 2, 2021 • edited Loading

Choose a reason for hiding this comment

smartie2076 Dec 8, 2021 • edited Loading

Choose a reason for hiding this comment

smartie2076 Dec 2, 2021

Choose a reason for hiding this comment

adnanalakori Dec 3, 2021 • edited Loading

Choose a reason for hiding this comment

smartie2076 Dec 8, 2021

Choose a reason for hiding this comment

smartie2076 Dec 2, 2021

Choose a reason for hiding this comment

smartie2076 Dec 8, 2021

Choose a reason for hiding this comment

smartie2076 Dec 2, 2021

Choose a reason for hiding this comment

adnanalakori Dec 2, 2021 • edited by smartie2076 Loading

Choose a reason for hiding this comment

smartie2076 Dec 8, 2021 • edited Loading

Choose a reason for hiding this comment

adnanalakori commented Dec 2, 2021 • edited Loading

adnanalakori commented Dec 1, 2021 •

edited

Loading

adnanalakori left a comment •

edited

Loading

adnanalakori Dec 2, 2021 •

edited

Loading

smartie2076 Dec 8, 2021 •

edited

Loading

adnanalakori Dec 3, 2021 •

edited

Loading

adnanalakori Dec 2, 2021 •

edited by smartie2076

Loading

smartie2076 Dec 8, 2021 •

edited

Loading

adnanalakori commented Dec 2, 2021 •

edited

Loading