Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvs_report from json_with_results #814

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from

Conversation

TheOneAndra
Copy link
Collaborator

@TheOneAndra TheOneAndra commented Mar 2, 2021

Fix #813

Changes proposed in this pull request:

  • minor change to allow the user to run mvs_report with a single json_with_results file.

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@TheOneAndra TheOneAndra requested a review from Bachibouzouk March 2, 2021 18:04
@TheOneAndra
Copy link
Collaborator Author

TheOneAndra commented Mar 2, 2021

At this stage mvs_report terminates with:

(MVS) C:\Andra\MVS_GitHub>mvs_report -i C:\Andra\RLI\Master_Thesis\Data\MVS\Simulations\Sensitivity_analysis\210203_GF_var\210210_simplistic_system_PV\outputs\json_with_results_1_1.json
WARNING:root:The assets folder C:\Andra\RLI\Master_Thesis\Data\MVS\Simulations\Sensitivity_analysis\210203_GF_var\210210_simplistic_system_PV\outputs\report\assets exists already, it will not be replaced by default folder from multi_vector_simulator's package
Traceback (most recent call last):
  File "C:\Users\andra.backhaus\.conda\envs\MVS\Scripts\mvs_report-script.py", line 33, in <module>
    sys.exit(load_entry_point('multi-vector-simulator', 'console_scripts', 'mvs_report')())
  File "c:\andra\mvs_github\src\multi_vector_simulator\cli.py", line 266, in report
    test_app = create_app(dict_values, path_sim_output=path_sim_output)
  File "c:\andra\mvs_github\src\multi_vector_simulator\F2_autoreport.py", line 1031, in create_app
    log_dict=results_json[SIMULATION_RESULTS][LOGS][
KeyError: 'logs'

The temporary solution is to comment a whole section in F2_autoreport but that just deletes log messages from the all reports.

@TheOneAndra TheOneAndra added the help wanted Extra attention is needed label Mar 4, 2021
@smartie2076
Copy link
Collaborator

@Bachibouzouk @TheOneAndra is this something that should be merged in the near future? If so, @TheOneAndra can you do a local rebase and force push (in coordination with @Bachibouzouk)?

@TheOneAndra
Copy link
Collaborator Author

@Bachibouzouk @TheOneAndra is this something that should be merged in the near future? If so, @TheOneAndra can you do a local rebase and force push (in coordination with @Bachibouzouk)?

This PR was made on request from PF so that he can have a trace of my local changes we made. I don't think this PR will be merged as is, but just used by PF at some point, maybe @Bachibouzouk you have another opinion?

@Bachibouzouk
Copy link
Collaborator

This does not need to be merged yet but it might be useful if users want to perform sensitivity analysis

@TheOneAndra
Copy link
Collaborator Author

@smartie2076 I placed an example of the code used for my sensitivity analysis in this PR under tests/test_data/example_data_sensitivity/

@smartie2076 smartie2076 force-pushed the feature/mvs_report_sensitivity branch from d079264 to 8c50877 Compare July 8, 2021 15:25
TheOneAndra and others added 21 commits March 30, 2022 12:50
Check for KPI_COST_MATRIX and KPI_SCALAR_MATRIX
- changes to `A0`
- Add `RUN_SENSITIVITY` to `constants.py`
- Replace `_` with spaces
- Use intuitive labels and correct units (from `docs/MVS_kpis_list.csv` and `docs/MVS_parameter_list.csv`
@Bachibouzouk Bachibouzouk force-pushed the feature/mvs_report_sensitivity branch from 0f5fa90 to 86c85dd Compare March 30, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in B0_data_input_json.py cause a simulation termination
3 participants