Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recency checks #609

Merged
merged 8 commits into from
Sep 13, 2024
Merged

Recency checks #609

merged 8 commits into from
Sep 13, 2024

Conversation

rjust
Copy link
Owner

@rjust rjust commented Sep 10, 2024

No description provided.

@rjust
Copy link
Owner Author

rjust commented Sep 10, 2024

@mernst Can you please flesh out the details in README.md (Reproducibility section) and in init.sh (summary table with a list of major changes).

@mernst
Copy link
Collaborator

mernst commented Sep 10, 2024

@rjust This looks good to me. However, CI is failing.

@mernst mernst assigned rjust and unassigned mernst Sep 10, 2024
@rjust
Copy link
Owner Author

rjust commented Sep 10, 2024

I fixed the bug-mining script that caused the test failure.

Depending on how we ensure reproducibility w.r.t. Locale settings, we should update the README and:

  • either describe the additional unit test that we are adding, which asserts on the environment settings (timezone and locale settings)
  • or remove the section about the Locale Provider if we patch the affected test files.

@rjust rjust merged commit f22e707 into java-11-compatibility Sep 13, 2024
2 checks passed
@rjust rjust deleted the recency-checks branch September 13, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants