-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancing Form with grid layout #693
Conversation
@phucpnt nobody will see it? |
this is cool but how would you handle responsive ? |
@revolunet it support desktop for grid layout. For mobile it will fallback to 1 column |
Hi, thanks for the PR. It looks good, but in general I would like to keep to a minimum the amount of visual/UI customization available as part of the rjsf package itself. The same way I don't want to support Material Design or Ant, I also don't want to have to support more than one layout mechanism. Is there some way that we could support this, or something like this, as a third-party extension? Are there things missing in the base rjsf library that would make doing so easier? If so, I would much rather support that, and let users/developers decide what layout they want to use in their projects. |
When will this be merged into master branch? |
@kharkut as far as I understood they are not planning to extend the project with this kind of functionality. I personally needed it too so I took the file from the merge request |
I think that this should be as a separate package or in some UI package. (related #899) |
let's merge this. |
Closing this PR because we already have this functionality in |
Sorry, but I don't think that
|
@Fedorov113 what I meant was, We can still implement a |
Thank you for your reply. I use this package a lot with Material UI theme, however I'm not primarily a JS developer. I really need this functionality and will try to implement it in my fork. |
this ticket seems to be closed, Is "ui:layout" supported with latest release 1.8.1? If its supported, how would we provide the layout options in a nested schema structure, the below example provided works only in a flat schema where the object properties are at root level, how would we define if they are nested for eg, name.fn, name.ln "ui:layout": [ |
Can anyone share sample example for this..... @phucpnt |
That would be great. I second the request, and would love to see the playground upgraded with this example.
…Sent from my iPhone
On Sep 17, 2020, at 3:37 AM, Mani-1112 ***@***.***> wrote:
Can anyone share sample example for this..... @phucpnt
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@Mani-1112 , @mromey you can check the sample at https://github.com/rjsf-team/react-jsonschema-form/pull/693/files#diff-5096d8cd13427dbf61c5ff143f034b98 |
Hi, The below syntax for layout will work on the latest rjsf package or not ? As when I tried the suggested code it didnt worked out uiSchema: { As I updated only UIschema and others do I need to add or latest rjsf package will handle? @phucpnt @epicfaace |
@Mani-1112 the PR is not merge yet. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please leave a comment if this is still an issue for you. Thank you. |
hi any news about this? |
@Mani-1112 <https://github.com/Mani-1112> the PR is not merge yet. Really
needs it to be Merged!
…On Thu, Aug 4, 2022 at 3:38 PM Juan Heyda ***@***.***> wrote:
hi any news about this?
—
Reply to this email directly, view it on GitHub
<#693 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENTFDAIXDQX7IIIFL4EHLTVXQS4PANCNFSM4DZXKIJQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
So much has changed since this PR was created. Especially the addition of 7 themes that this PR cannot support. Don't worry, there is effort underway to implement grid support in a MUCH richer way for all themes coming in 2023 (hopefully). Stay tuned |
Reasons for making this change
Enhancing Form with grid layout.
Adding new configuration
ui:layout
for uiSchema.Checklist
npm run cs-format
on my branch to conform my code to prettier coding style