Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing Form with grid layout #693

Closed
wants to merge 2 commits into from
Closed

Conversation

phucpnt
Copy link

@phucpnt phucpnt commented Sep 6, 2017

Reasons for making this change

Enhancing Form with grid layout.
Adding new configuration ui:layout for uiSchema.

Checklist

  • I'm updating documentation
    • I've checked the rendering of the Markdown text I've added
    • If I'm adding a new section, I've updated the Table of Content
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've run npm run cs-format on my branch to conform my code to prettier coding style
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@santosguilherme
Copy link

@phucpnt nobody will see it?

@santosguilherme santosguilherme mentioned this pull request Dec 4, 2017
@revolunet
Copy link
Contributor

this is cool but how would you handle responsive ?

@phucpnt
Copy link
Author

phucpnt commented Jan 26, 2018

@revolunet it support desktop for grid layout. For mobile it will fallback to 1 column

@glasserc
Copy link
Contributor

Hi, thanks for the PR. It looks good, but in general I would like to keep to a minimum the amount of visual/UI customization available as part of the rjsf package itself. The same way I don't want to support Material Design or Ant, I also don't want to have to support more than one layout mechanism. Is there some way that we could support this, or something like this, as a third-party extension? Are there things missing in the base rjsf library that would make doing so easier? If so, I would much rather support that, and let users/developers decide what layout they want to use in their projects.

@kharkut
Copy link

kharkut commented Apr 2, 2018

When will this be merged into master branch?

@random-one
Copy link

@kharkut as far as I understood they are not planning to extend the project with this kind of functionality. I personally needed it too so I took the file from the merge request withLayout.js in my project and used it like in the example.

@MatejBransky
Copy link

I think that this should be as a separate package or in some UI package. (related #899)

@zetekla
Copy link

zetekla commented Nov 3, 2018

let's merge this.

@epicfaace
Copy link
Member

Closing this PR because we already have this functionality in withTheme.

@epicfaace epicfaace closed this Dec 22, 2019
@Fedorov113
Copy link

Closing this PR because we already have this functionality in withTheme.

Sorry, but I don't think that withTheme allows to build grid layouts like this PR purposes.

"ui:layout": [
      [{ firstName: 6 }, { lastName: 6 }],
      [{ password: 6 }],
      [{ age: 6 }, { telephone: 6 }],
      [{ bio: 12 }],
    ]

@epicfaace
Copy link
Member

@Fedorov113 what I meant was, withTheme is already a HOC that allows for form theme customization. We don't need another HOC called withLayout.

We can still implement a ui:layout functionality, but this would likely need to be implemented for each theme that we support.

@Fedorov113
Copy link

@Fedorov113 what I meant was, withTheme is already a HOC that allows for form theme customization. We don't need another HOC called withLayout.

We can still implement a ui:layout functionality, but this would likely need to be implemented for each theme that we support.

Thank you for your reply.

I use this package a lot with Material UI theme, however I'm not primarily a JS developer. I really need this functionality and will try to implement it in my fork.
Can you please give some advice on where to start? Is the code in the PR too outdated?

@hiitskiran
Copy link

hiitskiran commented Jul 17, 2020

this ticket seems to be closed, Is "ui:layout" supported with latest release 1.8.1? If its supported, how would we provide the layout options in a nested schema structure, the below example provided works only in a flat schema where the object properties are at root level, how would we define if they are nested for eg, name.fn, name.ln

"ui:layout": [
[{ firstName: 6 }, { lastName: 6 }],
[{ password: 6 }],
[{ age: 6 }, { telephone: 6 }],
[{ bio: 12 }],
]

@Mani-1112
Copy link

Can anyone share sample example for this..... @phucpnt

@mromey
Copy link

mromey commented Sep 17, 2020 via email

@epicfaace epicfaace reopened this Sep 17, 2020
@phucpnt
Copy link
Author

phucpnt commented Sep 18, 2020

@Mani-1112
Copy link

Hi,

The below syntax for layout will work on the latest rjsf package or not ? As when I tried the suggested code it didnt worked out

uiSchema: {
"ui:layout": [
[{ firstName: 6 }, { lastName: 6 }],
[{ password: 6 }],
[{ age: 6 }, { telephone: 6 }],
[{ bio: 12 }],
],

As I updated only UIschema and others do I need to add or latest rjsf package will handle? @phucpnt @epicfaace

@phucpnt
Copy link
Author

phucpnt commented Sep 29, 2020

@Mani-1112 the PR is not merge yet.

@stale
Copy link

stale bot commented Jul 22, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please leave a comment if this is still an issue for you. Thank you.

@stale stale bot added the wontfix label Jul 22, 2022
@JuanHeyda
Copy link

hi any news about this?

@stale stale bot removed the wontfix label Aug 4, 2022
@zetekla
Copy link

zetekla commented Aug 5, 2022 via email

@heath-freenome
Copy link
Member

So much has changed since this PR was created. Especially the addition of 7 themes that this PR cannot support. Don't worry, there is effort underway to implement grid support in a MUCH richer way for all themes coming in 2023 (hopefully). Stay tuned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.