Fix CheckboxesWidget and RadioWidget style

[maartenth]

Reasons for making this change

Unfortunately I currently don't have time for the 'bigger' issues, but this is a simple style fix I think will make many forms look better.

Some context:
The label in a CheckboxWidget is bold, and rightly so, because the label of a CheckboxWidget is the field title and all field titles are bold. The labels in a RadioWidget are not bold, unless the option inline: true is set.

Issue 1:
The labels in the CheckboxesWidget are bold too. I think this is done for consistency with CheckboxWidget, but I think consistency with RadioWidget would be better, because the labels of a CheckboxesWidget are not titles but enumNames. Now it could lead to an enormous wall of bold text for large enums, and the real field title does not stand out any more. I changed this in this pull request.

Issue 2:
The labels in RadioWidget and CheckboxesWidget were bold when inline: true was set. This was due to a styling issue with Bootstrap, which needs another DOM structure for inline widgets (class radio-inline or checkbox-inline must be set on <label> itself instead of on a wrapper <div>). I fixed this too.

Issue 3:
While I was working on it, I saw that in CheckboxesWidget the disabled class was not set for disabled inputs. I fixed this like it was done for CheckboxWidget and RadioWidget.

Checklist

• I'm updating documentation
  • I've checked the rendering of the Markdown text I've added
  • If I'm adding a new section, I've updated the Table of Content
• I'm adding or updating code
  • I've added and/or updated tests
  • I've updated docs if needed
• I'm adding a new feature
  • I've updated the playground with an example use of the feature

[n1k0]

Looks good to me. Thank you :)

[n1k0]

Released along v0.41.2.

[wintercounter]

This is great, but you removed <strong> from the markup which I used to style my checkboxes: input:checked + strong
I was happy that at least checkboxes had a wrapper for text. Please wrap the text into something so it'll be possible to use the :checked selector for both radio and checkbox. Just an empty span at least.

[maartenth]

@wintercounter I'm not the one who decides but I think a <span> would not hurt anyone, you could do a PR to fix it for both CheckboxWidget, CheckboxesWidget and RadioWidget.

[n1k0]

I agree! Le 6 déc. 2016 12:50 PM, "Maarten ter Horst" <[email protected]> a écrit :

…

@wintercounter <https://github.com/wintercounter> I'm not the one who decides but I think a <span> would not hurt anyone, you could do a PR to fix it for both CheckboxWidget, CheckboxesWidget and RadioWidget. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#403 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACiSy4JKIImDK0Xq6Ivymrlu1tAwE6uks5rFUwDgaJpZM4K4d80> .