-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to customize form titles. #38
Conversation
Use a registry rather than passing yet another prop to children.
it("should render a customized title", () => { | ||
const CustomTitleField = function(props) { | ||
return (<div id="custom">{ props.title }</div>); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
const CustomTitleField = ({title}) => <div id="custom">{title}</div>;
Note: This will break BC for consumers of the current API, because you now have to pass a registry object instead of a SchemaField. We need to document this change in the release notes with a big red warning, and to update the docs appropriately. |
This won't, you still pass |
After feedback from @n1k0.
Ah right, cool. So we only need to update the docs and we're good to go with nits addressed. |
Docs updated. |
LGTM, r+ |
Could you take care of releasing v0.11.0? |
Did this: npm run dist
vim package.json
npm publish
git commit -am "Bump v0.11.0"
git tag v0.11.0
git push |
No |
In the Despite that, I still need to run |
Ah no it's fine then :) |
Use a registry rather than passing yet another prop to children.
r? @n1k0