Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to customize form titles. #38

Merged
merged 4 commits into from
Feb 22, 2016
Merged

Allow to customize form titles. #38

merged 4 commits into from
Feb 22, 2016

Conversation

almet
Copy link
Contributor

@almet almet commented Feb 22, 2016

Use a registry rather than passing yet another prop to children.

r? @n1k0

Use a registry rather than passing yet another prop to children.
it("should render a customized title", () => {
const CustomTitleField = function(props) {
return (<div id="custom">{ props.title }</div>);
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

const CustomTitleField = ({title}) => <div id="custom">{title}</div>;

@n1k0
Copy link
Collaborator

n1k0 commented Feb 22, 2016

Note: This will break BC for consumers of the current API, because you now have to pass a registry object instead of a SchemaField. We need to document this change in the release notes with a big red warning, and to update the docs appropriately.

@almet
Copy link
Contributor Author

almet commented Feb 22, 2016

Note: This will break BC for consumers of the current API, because you now have to pass a registry object instead of a SchemaField. We need to document this change in the release notes with a big red warning.

This won't, you still pass SchemaField, the registry is only exposed internally.

@n1k0
Copy link
Collaborator

n1k0 commented Feb 22, 2016

Ah right, cool. So we only need to update the docs and we're good to go with nits addressed.

@almet
Copy link
Contributor Author

almet commented Feb 22, 2016

Docs updated.

@n1k0
Copy link
Collaborator

n1k0 commented Feb 22, 2016

LGTM, r+

almet added a commit that referenced this pull request Feb 22, 2016
@almet almet merged commit b1b6392 into master Feb 22, 2016
@almet almet deleted the registry-titlefield branch February 22, 2016 13:18
@n1k0
Copy link
Collaborator

n1k0 commented Feb 22, 2016

Could you take care of releasing v0.11.0?

@almet
Copy link
Contributor Author

almet commented Feb 22, 2016

Did this:

npm run dist
vim package.json
npm publish
git commit -am "Bump v0.11.0"
git tag v0.11.0
git push

@n1k0
Copy link
Collaborator

n1k0 commented Feb 22, 2016

No npm run build? Did you test installing the package after the release?

@almet
Copy link
Contributor Author

almet commented Feb 22, 2016

In the package.json file, I see "dist": "npm run build:lib && npm run build:dist && npm run build:css",.

Despite that, I still need to run npm run build?

@n1k0
Copy link
Collaborator

n1k0 commented Feb 22, 2016

Ah no it's fine then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants