fix: Switch to using isValid() for oneOf schema detection in retrieveSchema() #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
force-pushed
the
switch-to-isValid
branch
2 times, most recently
from
4c2520a to
78383d8
Compare
…Schema() Added an optimization in `retrieveSchema()` to use the `isValid()` function rather than `validateFormData()` - In `@rjsf/utils`, switched the `withExactlyOneSubschema()` to use `isValid()` - Updated the test mocks accordingly
heath-freenome
force-pushed
the
switch-to-isValid
branch
from
78383d8 to
ecc4b1c
Compare
heath-freenome
commented
Apr 4, 2023
| @@ -209,7 +209,6 @@ describeRepeated('Form common', (createFormComponent) => { | |||
|
|
|||
| it('should work with oneOf', function () { | |||
| const schema = { | |||
| $schema: 'http://json-schema.org/draft-06/schema#', | |||
There was a problem hiding this comment.
This caused compilation errors that broke the isValid() checks but didn't affect the old validateFormData() checks because that handled the error differently
nickgros
approved these changes
Apr 4, 2023
4 tasks
cewald
added a commit
to spiribo/react-jsonschema-form
that referenced
this pull request
Dec 16, 2024
…retrieveSchema() (rjsf-team#3575)" This reverts commit ff46301.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Added an optimization in
retrieveSchema()to use theisValid()function rather thanvalidateFormData()@rjsf/utils, switched thewithExactlyOneSubschema()to useisValid()Checklist
npm run test:updateto update snapshots, if needed.