Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package links in README files #3094

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Fix package links in README files #3094

merged 3 commits into from
Sep 8, 2022

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Sep 7, 2022 •
edited
Loading

Reasons for making this change

  • some of the links in the README files, as these propagate to npm, etc.
    • congratulations on the releases!
  • updates the logo pointers to current master (7ebc866)
    • though they are still probably incorrect

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

@bollwyvl Can you update the CHANGELOG.md file, apply the suggestion and rebase your branch?

@heath-freenome
Copy link
Member

@bollwyvl Can you update the CHANGELOG.md file, apply the suggestion and rebase your branch?

@bollwyvl Nevermind, I am updating the CHANGELOG.md for a different change and will add something for this fix

@heath-freenome heath-freenome merged commit 0d0cace into rjsf-team:master Sep 8, 2022
heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this pull request Sep 8, 2022
@heath-freenome
Reimplemented fix in rjsf-team#2198 in @rjsf/utils package
c8e5389 
- The fix in rjsf-team#2198 needed to be refactored into the new `@rjsf/utils` package
- Replicated the fix into the `getDefaultFormState.ts` file
- Replicated the additional tests into `getDefaultFormStateTest.ts` and `oneOf_test.js`
- Updated the `CHANGELOG.md` with the note for this fix along with the notes for PR rjsf-team#3094
heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this pull request Sep 8, 2022
@heath-freenome
Reimplemented fix in rjsf-team#2198 in @rjsf/utils package
eb2fad9 
- The fix in rjsf-team#2198 needed to be refactored into the new `@rjsf/utils` package
- Replicated the fix into the `getDefaultFormState.ts` file
- Replicated the additional tests into `getDefaultFormStateTest.ts` and `oneOf_test.js`
- Updated the `CHANGELOG.md` with the note for this fix along with the notes for PR rjsf-team#3094
heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this pull request Sep 8, 2022
@heath-freenome
Reimplemented fix in rjsf-team#2198 in @rjsf/utils package
0f16820 
- The fix in rjsf-team#2198 needed to be refactored into the new `@rjsf/utils` package
- Replicated the fix into the `getDefaultFormState.ts` file
- Replicated the additional tests into `getDefaultFormStateTest.ts` and `oneOf_test.js`
- Updated the `CHANGELOG.md` with the note for this fix along with the notes for PR rjsf-team#3094
@heath-freenome heath-freenome mentioned this pull request Sep 8, 2022
Merged
8 tasks
heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this pull request Sep 8, 2022
@heath-freenome
Reimplemented fix in rjsf-team#2198 in @rjsf/utils package
720769c 
- The fix in rjsf-team#2198 needed to be refactored into the new `@rjsf/utils` package
- Replicated the fix into the `getDefaultFormState.ts` file
- Replicated the additional tests into `getDefaultFormStateTest.ts` and `oneOf_test.js`
- Updated the `CHANGELOG.md` with the note for this fix along with the notes for PR rjsf-team#3094
heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this pull request Sep 8, 2022
@heath-freenome
Reimplemented fix in rjsf-team#2198 in @rjsf/utils package
a036a93 
- The fix in rjsf-team#2198 needed to be refactored into the new `@rjsf/utils` package
- Replicated the fix into the `getDefaultFormState.ts` file
- Replicated the additional tests into `getDefaultFormStateTest.ts` and `oneOf_test.js`
- Updated the `CHANGELOG.md` with the note for this fix along with the notes for PR rjsf-team#3094
heath-freenome added a commit that referenced this pull request Sep 8, 2022
@heath-freenome
Reimplemented fix in #2198 in @rjsf/utils package (#3099)
3a12804 
* Reimplemented fix in #2198 in @rjsf/utils package
- The fix in #2198 needed to be refactored into the new `@rjsf/utils` package
- Replicated the fix into the `getDefaultFormState.ts` file
- Replicated the additional tests into `getDefaultFormStateTest.ts` and `oneOf_test.js`
- Updated the `CHANGELOG.md` with the note for this fix along with the notes for PR #3094

* - Updated `CHANGELOG.md` for PR #2925

* - Fixed up `CHANGELOG.md` to move note from #3049 into the proper location
@bollwyvl bollwyvl deleted the fix-readme-links branch September 8, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heath-freenome heath-freenome heath-freenome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bollwyvl @heath-freenome