Reimplement #2369 in both material ui themes #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heath-freenome
requested review from
epicfaace,
jimmycallin,
jacqueswho and
nickgros
jacqueswho
approved these changes
Aug 29, 2022
- Updated the `BaseInputTemplate` in both `@rjsf/material-ui` and `@rjsf/mui` to add the examples implementation from rjsf-team#2369 - Added the `schema.examples` tests in the `Form.test.tsx`
…ious commit - Commit the `semantic-ui` lock file since it was updated on my install
- Updated tests accordingly - Also added `source-map-loader` to `playground` dev dependencies to fix playground
heath-freenome
force-pushed
the
reimplement-2369-to-fix-2368
branch
from
c6bea91 to
8e88cd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #2368, #2557
BaseInputTemplatein both@rjsf/material-uiand@rjsf/muito add the examples implementation from "examples" implementation for material-ui #2369antd,fluent-uiandsemantic-uitheme in a similar mannerschema.examplestests in theForm.test.tsxsource-map-loaderpackage-lock.jsonfor thesemantic-uipackageCHANGELOG.mdfile to add these as well assemantic-uichangesChecklist
npm run test:updateto update snapshots, if needed.