Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change boolean custom tag to bsPrefix. #3049

Merged
merged 5 commits into from
Sep 8, 2022
Merged

Change boolean custom tag to bsPrefix. #3049

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
effdcba
Change boolean custom tag to bsPrefix.
WillowP Aug 26, 2022
eea3362
Update CHANGELOG.md
WillowP Aug 26, 2022
fd163e4
Merge branch 'master' into fix/select-widget-custom-tag
heath-freenome Sep 7, 2022
e28fe15
Merge branch 'master' into fix/select-widget-custom-tag
heath-freenome Sep 8, 2022
86af532
Merge branch 'master' into fix/select-widget-custom-tag
heath-freenome Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ should change the heading of the (upcoming) version to include a major version b
* docs: fix schema dependencies link by @epicfaace in https://github.com/rjsf-team/react-jsonschema-form/pull/2885
* chore(deps): bump core-js-pure from 3.21.1 to 3.23.3 by @dependabot in https://github.com/rjsf-team/react-jsonschema-form/pull/2902
* chore(deps): bump minimist from 1.2.5 to 1.2.6 in /packages/fluent-ui by @dependabot in https://github.com/rjsf-team/react-jsonschema-form/pull/2805
* fix(@rjsf/bootstrap-4): Change custom attribute to bsPrefix by @WillowP in https://github.com/rjsf-team/react-jsonschema-form/pull/3049

# 4.2.0

Expand Down
2 changes: 1 addition & 1 deletion packages/bootstrap-4/src/SelectWidget/SelectWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ const SelectWidget = ({
</Form.Label>
<Form.Control
as="select"
custom
bsPrefix="custom-select"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I just removed custom, the tests failed because the className changed from custom-select to form-control. The bsPrefix prop seems to be the way to approach this, based on the docs at https://react-bootstrap.github.io/forms/form-control/#form-control-props

Copy link
Member

@heath-freenome heath-freenome Aug 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things... First, it would be better to put this change into the upcoming rjsf-v5 beta branch, so can you please rebase and do it there? Second, please reference the issue you are fixing in the CHANGELOG.md.

id={id}
value={typeof value === "undefined" ? emptyValue : value}
required={required}
Expand Down