clear errors from "additionalProperties: false" #2631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove added debug script for test purpose from package.json
| @@ -16,8 +16,7 @@ | |||
| "start": "concurrently \"npm:build:* -- --watch\"", | |||
| "tdd": "cross-env NODE_ENV=test mocha --require @babel/register --watch --require ./test/setup-jsdom.js test/**/*_test.js", | |||
| "test": "cross-env BABEL_ENV=test NODE_ENV=test mocha --require @babel/register --require ./test/setup-jsdom.js test/**/*_test.js", | |||
| "test-coverage": "cross-env NODE_ENV=test nyc --reporter=lcov mocha --require @babel/register --require ./test/setup-jsdom.js test/**/*_test.js", | |||
| "test-debug": "cross-env NODE_ENV=test mocha --require @babel/register --require ./test/setup-jsdom.js --debug-brk --inspect test/Form_test.js" | |||
There was a problem hiding this comment.
I've added the test-debug to work on dedicated Form_test and commit it by accident.
There was a problem hiding this comment.
Honestly, it is actually a nice add! I'd suggest keeping it
|
@Lausselloic in the upcoming @rjsf v5 release the utils.js and validator.js files have been refactored into their own packages (see the rjsf-v5 branch). If you feel that this change is critical, I encourage you to port it onto that branch. |
Lausselloic
added a commit
to Lausselloic/react-jsonschema-form
that referenced
this pull request
Jul 19, 2022
…set to false in schema
Lausselloic
added a commit
to Lausselloic/react-jsonschema-form
that referenced
this pull request
Jul 22, 2022
…set to false in schema # Conflicts: # packages/utils/src/schema/toPathSchema.ts # packages/utils/test/schema/toPathSchemaTest.ts
Lausselloic
added a commit
to Lausselloic/react-jsonschema-form
that referenced
this pull request
Jul 29, 2022
…set to false in schema # Conflicts: # packages/utils/src/schema/toPathSchema.ts # packages/utils/test/schema/toPathSchemaTest.ts
heath-freenome
added a commit
that referenced
this pull request
Aug 19, 2022
…lse (#2940) * backport PR #2631 to take into account additionalProperties set to false in schema # Conflicts: # packages/utils/src/schema/toPathSchema.ts # packages/utils/test/schema/toPathSchemaTest.ts * move to fix from #2853 * fix linting error * run cs-format on modified files * Update packages/utils/src/schema/toPathSchema.ts Fix formatting (hopefully) * Update packages/utils/src/schema/toPathSchema.ts Second try fixing formatting Co-authored-by: LAUSSEL Loic INNOV/IT-S <[email protected]> Co-authored-by: Heath C <[email protected]>
heath-freenome
added a commit
to heath-freenome/react-jsonschema-form
that referenced
this pull request
Aug 27, 2022
…set to false (rjsf-team#2940) * backport PR rjsf-team#2631 to take into account additionalProperties set to false in schema # Conflicts: # packages/utils/src/schema/toPathSchema.ts # packages/utils/test/schema/toPathSchemaTest.ts * move to fix from rjsf-team#2853 * fix linting error * run cs-format on modified files * Update packages/utils/src/schema/toPathSchema.ts Fix formatting (hopefully) * Update packages/utils/src/schema/toPathSchema.ts Second try fixing formatting Co-authored-by: LAUSSEL Loic INNOV/IT-S <[email protected]> Co-authored-by: Heath C <[email protected]>
|
Fixed in v5 beta via #2940, see the 5.x migration guide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
if additionalProperties is set to
falseomit extra data doesn't work as expectedAdd a test to validate it. Before fixes test failed, after fix test success
Fixes #1507
Checklist