Fix dependency defaults for uncontrolled components #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epicfaace
changed the title
edi9999
approved these changes
Jul 30, 2019
This was referenced Aug 11, 2019
epicfaace
added a commit
that referenced
this pull request
Dec 7, 2019
* feat: add allOf support * use patch version of json-schema-merge-allof * fix: publicPath for netlify builds * fix typo * fix: pass around shouldMergeAllOf a bit * fix: remove shouldMergeAllOf * fix: resolve allOf when calculating idSchema and pathSchema * Revert "Fix dependency defaults for uncontrolled components (#1371)" This reverts commit 6728977. * Revert "Revert "Fix dependency defaults for uncontrolled components (#1371)"" This reverts commit ad2bd68. * test: start writing some basic tests * add doc on allOf * add allOf playground sample * handle merging errors by removing allOf * add test for nested allOf's * clarify that allOf keyword is dropped * don't use merge allof fork * remove change to package-lock.json * prettier format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #1316.
Also fixes #1370.
If this is related to existing tickets, include links to them as well.
Checklist