npm unpkg verion 1.0.4 is broken, 1.0.3 works

[pieper]

Prerequisites

• [x ] I have read the documentation;
• [ x] In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description

I get an error loading a site with the current version on unpkg

Steps to Reproduce

http://pieper.github.io/sites/schemaform/index.html

Gives this error:

Uncaught TypeError: a is not a function
    at Object.<anonymous> (es6.object.define-property.js:3)
    at t (bootstrap 7fcccad7da765f90bc6a:19)
    at Object.<anonymous> (define-property.js:1)
    at t (bootstrap 7fcccad7da765f90bc6a:19)
    at Object.<anonymous> (define-property.js:1)
    at t (bootstrap 7fcccad7da765f90bc6a:19)
    at Object.<anonymous> (react-jsonschema-form.js:879)
    at t (bootstrap 7fcccad7da765f90bc6a:19)
    at Object.<anonymous> (_hide.js:1)
    at t (bootstrap 7fcccad7da765f90bc6a:19)

If I change the script to use 1.0.3 it works:

  <script src="https://unpkg.com/[email protected]/dist/react-jsonschema-form.js"></script>

Expected behavior

1.0.4 shouldn't raise an error

Actual behavior

The error happens independent of my code.

Version

1.0.4

[graingert]

this is because we're transpiling core-js with babel-transform-runtime

[graingert]

the fix is to either whitelist packages to transform with babel-loader (eg react and react-dom) or blacklist node_module\/((babel-[\w\d-]+)|core-js)/.*

[glasserc]

OK, I think I fixed this in 1.0.5. Please let me know if you still experience this problem.

[pieper]

The other error doesn't occur, but now I get this.

schemaformDemo.js:62 Uncaught TypeError: Cannot read property 'parentElement' of null
    at Object.customOnChange [as onChange] (schemaformDemo.js:62)
    at new t (Form.js:33)
    at constructClassInstance (react-dom.development.js:11892)
    at updateClassComponent (react-dom.development.js:13614)
    at beginWork (react-dom.development.js:14213)
    at performUnitOfWork (react-dom.development.js:16539)
    at workLoop (react-dom.development.js:16577)
    at HTMLUnknownElement.callCallback (react-dom.development.js:139)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:189)
    at invokeGuardedCallback (react-dom.development.js:242)
customOnChange @ schemaformDemo.js:62
t @ Form.js:33
constructClassInstance @ react-dom.development.js:11892
updateClassComponent @ react-dom.development.js:13614
beginWork @ react-dom.development.js:14213
performUnitOfWork @ react-dom.development.js:16539
workLoop @ react-dom.development.js:16577
callCallback @ react-dom.development.js:139
invokeGuardedCallbackDev @ react-dom.development.js:189
invokeGuardedCallback @ react-dom.development.js:242
replayUnitOfWork @ react-dom.development.js:15868
renderRoot @ react-dom.development.js:16671
performWorkOnRoot @ react-dom.development.js:17510
performWork @ react-dom.development.js:17418
performSyncWork @ react-dom.development.js:17390
requestWork @ react-dom.development.js:17278
scheduleWork @ react-dom.development.js:17072
scheduleRootUpdate @ react-dom.development.js:17760
updateContainerAtExpirationTime @ react-dom.development.js:17787
updateContainer @ react-dom.development.js:17814
ReactRoot.render @ react-dom.development.js:18080
(anonymous) @ react-dom.development.js:18220
unbatchedUpdates @ react-dom.development.js:17641
legacyRenderSubtreeIntoContainer @ react-dom.development.js:18216
render @ react-dom.development.js:18275
schemaformDemo @ schemaformDemo.js:82
document.addEventListener @ (index):23
react-dom.development.js:14673 The above error occurred in the <t> component:
    in t

Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://fb.me/react-error-boundaries to learn more about error boundaries.
logCapturedError @ react-dom.development.js:14673
logError @ react-dom.development.js:14709
update.callback @ react-dom.development.js:15396
callCallback @ react-dom.development.js:11256
commitUpdateEffects @ react-dom.development.js:11295
commitUpdateQueue @ react-dom.development.js:11286
commitLifeCycles @ react-dom.development.js:14844
commitAllLifeCycles @ react-dom.development.js:16028
callCallback @ react-dom.development.js:139
invokeGuardedCallbackDev @ react-dom.development.js:189
invokeGuardedCallback @ react-dom.development.js:242
commitRoot @ react-dom.development.js:16198
completeRoot @ react-dom.development.js:17586
performWorkOnRoot @ react-dom.development.js:17514
performWork @ react-dom.development.js:17418
performSyncWork @ react-dom.development.js:17390
requestWork @ react-dom.development.js:17278
scheduleWork @ react-dom.development.js:17072
scheduleRootUpdate @ react-dom.development.js:17760
updateContainerAtExpirationTime @ react-dom.development.js:17787
updateContainer @ react-dom.development.js:17814
ReactRoot.render @ react-dom.development.js:18080
(anonymous) @ react-dom.development.js:18220
unbatchedUpdates @ react-dom.development.js:17641
legacyRenderSubtreeIntoContainer @ react-dom.development.js:18216
render @ react-dom.development.js:18275
schemaformDemo @ schemaformDemo.js:82
document.addEventListener @ (index):23
react-dom.development.js:17479 Uncaught TypeError: Cannot read property 'parentElement' of null
    at Object.customOnChange [as onChange] (schemaformDemo.js:62)
    at new t (Form.js:33)
    at constructClassInstance (react-dom.development.js:11892)
    at updateClassComponent (react-dom.development.js:13614)
    at beginWork (react-dom.development.js:14213)
    at performUnitOfWork (react-dom.development.js:16539)
    at workLoop (react-dom.development.js:16577)
    at renderRoot (react-dom.development.js:16656)
    at performWorkOnRoot (react-dom.development.js:17510)
    at performWork (react-dom.development.js:17418)
customOnChange @ schemaformDemo.js:62
t @ Form.js:33
constructClassInstance @ react-dom.development.js:11892
updateClassComponent @ react-dom.development.js:13614
beginWork @ react-dom.development.js:14213
performUnitOfWork @ react-dom.development.js:16539
workLoop @ react-dom.development.js:16577
renderRoot @ react-dom.development.js:16656
performWorkOnRoot @ react-dom.development.js:17510
performWork @ react-dom.development.js:17418
performSyncWork @ react-dom.development.js:17390
requestWork @ react-dom.development.js:17278
scheduleWork @ react-dom.development.js:17072
scheduleRootUpdate @ react-dom.development.js:17760
updateContainerAtExpirationTime @ react-dom.development.js:17787
updateContainer @ react-dom.development.js:17814
ReactRoot.render @ react-dom.development.js:18080
(anonymous) @ react-dom.development.js:18220
unbatchedUpdates @ react-dom.development.js:17641
legacyRenderSubtreeIntoContainer @ react-dom.development.js:18216
render @ react-dom.development.js:18275
schemaformDemo @ schemaformDemo.js:82
document.addEventListener @ (index):23

[graingert]

@pieper I get TypeError: titleEleement is null[Learn More] on firefox

[graingert]

@pieper can you open another bug - looks like onChange is getting called immediately after rendering

[graingert]

@pieper looks like it was this change: 9813483