react error on rendering with v1.0.5

[pieper]

Prerequisites

• [ x] I have read the documentation;
• [ x] In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description

Error using form

Related to #991

Steps to Reproduce

Load this page and look in the log

http://pieper.github.io/sites/schemaform/bug-1.0.5.html

Expected behavior

Should be a simple example form

Actual behavior

Error messages pasted below

Version

1.0.5 (1.0.3 worked, 1.0.4 had different error)

Tested on Chrome.

Error messages:

Uncaught TypeError: Cannot read property 'parentElement' of null
    at Object.customOnChange [as onChange] (schemaformDemo.js:62)
    at new t (Form.js:33)
    at constructClassInstance (react-dom.development.js:11892)
    at updateClassComponent (react-dom.development.js:13614)
    at beginWork (react-dom.development.js:14213)
    at performUnitOfWork (react-dom.development.js:16539)
    at workLoop (react-dom.development.js:16577)
    at HTMLUnknownElement.callCallback (react-dom.development.js:139)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:189)
    at invokeGuardedCallback (react-dom.development.js:242)
react-dom.development.js:14673 The above error occurred in the <t> component:
    in t

Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://fb.me/react-error-boundaries to learn more about error boundaries.
logCapturedError @ react-dom.development.js:14673
react-dom.development.js:17479 Uncaught TypeError: Cannot read property 'parentElement' of null
    at Object.customOnChange [as onChange] (schemaformDemo.js:62)
    at new t (Form.js:33)
    at constructClassInstance (react-dom.development.js:11892)
    at updateClassComponent (react-dom.development.js:13614)
    at beginWork (react-dom.development.js:14213)
    at performUnitOfWork (react-dom.development.js:16539)
    at workLoop (react-dom.development.js:16577)
    at renderRoot (react-dom.development.js:16656)
    at performWorkOnRoot (react-dom.development.js:17510)
    at performWork (react-dom.development.js:17418)

[glasserc]

From comments on #991, it seems like this is due to #1034. @llamamoray, any thoughts?

[llamamoray]

This might be a bit off topic, but do you achieve hiding a field by accessing the DOM node in production code? This doesn't feel particularly robust to me. If I wanted to implement this kind of logic I'd be far more comfortable writing my own widget or using the oneOf functionality.

[pkosiec]

Hi, is anybody working on the issue?

[derberg]

@glasserc & @llamamoray do you know what are the plans for next release? is 1.0.6 blocked by this issue, if yes, how can we help?

[llamamoray]

See my comment above, I don't see how the example given is a sensible implementation of what was trying to be achieved.

[derberg]

@llamamoray if there is no response from the reporter, you think it is not a release blocker, maybe the decision should be to publick 1.0.6 🙈

[glasserc]

Yeah, I agree with @llamamoray -- modifying the DOM directly is super brittle and not very React-y, so I don't think we should support this, so I don't think we need to specify whether the onChange function gets run before or after the DOM instantiation. I'll try to cut a 1.0.6 release.

[pieper]

Thanks for looking at this 👍 Yes, if the example doesn't demonstrate a valid use case then it's fine for this issue to be closed.

At the time I was testing I didn't see another way to implement the UI I was looking for, and it did work in the previous release. When I have time to look at the project again maybe I'll find new functionality or I can ask for pointers about preferred implementations.