deprecate Supplier<Response> constructors in HandledTransportAction (e…

…lastic#44456)

This commit deprecates all constructors of HandledTransportAction
that take in a Supplier instead of a Writeable.Reader for response
objects.

in addition to the deprecation, the following modules were updated to
leverage Writeable

- modules:ingest-common
- modules:lang-mustache

relates elastic#34389.

modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/GrokProcessorGetAction.java

@@ -55,16 +55,17 @@ private GrokProcessorGetAction() {
     }
 
     public static class Request extends ActionRequest {
-        @Override
-        public ActionRequestValidationException validate() {
-            return null;
-        }
 
-        Request() {}
+        public Request() {}
 
         Request(StreamInput in) throws IOException {
             super(in);
         }
+
+        @Override
+        public ActionRequestValidationException validate() {
+            return null;
+        }
     }
 
     public static class Response extends ActionResponse implements ToXContentObject {

modules/lang-mustache/src/main/java/org/elasticsearch/script/mustache/MultiSearchTemplateAction.java

@@ -20,7 +20,6 @@
 package org.elasticsearch.script.mustache;
 
 import org.elasticsearch.action.ActionType;
-import org.elasticsearch.common.io.stream.Writeable;
 
 public class MultiSearchTemplateAction extends ActionType<MultiSearchTemplateResponse> {
 
@@ -30,9 +29,4 @@ public class MultiSearchTemplateAction extends ActionType<MultiSearchTemplateRes
     private MultiSearchTemplateAction() {
         super(NAME, MultiSearchTemplateResponse::new);
     }
-
-    @Override
-    public Writeable.Reader<MultiSearchTemplateResponse> getResponseReader() {
-        return MultiSearchTemplateResponse::new;
-    }
 }

modules/lang-mustache/src/main/java/org/elasticsearch/script/mustache/MultiSearchTemplateRequest.java

@@ -49,10 +49,10 @@ public class MultiSearchTemplateRequest extends ActionRequest implements Composi
 
     public MultiSearchTemplateRequest() {}
 
-    public MultiSearchTemplateRequest(StreamInput in) throws IOException {
+    MultiSearchTemplateRequest(StreamInput in) throws IOException {
         super(in);
         maxConcurrentSearchRequests = in.readVInt();
-        requests = in.readStreamableList(SearchTemplateRequest::new);
+        requests = in.readList(SearchTemplateRequest::new);
     }
 
     /**

server/src/main/java/org/elasticsearch/action/support/HandledTransportAction.java

@@ -34,6 +34,10 @@
  */
 public abstract class HandledTransportAction<Request extends ActionRequest, Response extends ActionResponse>
         extends TransportAction<Request, Response> {
+    /**
+     * @deprecated Use {@link #HandledTransportAction(String, TransportService, ActionFilters, Writeable.Reader)} instead.
+     */
+    @Deprecated
     protected HandledTransportAction(String actionName, TransportService transportService,
                                      Supplier<Request> request, ActionFilters actionFilters) {
         this(actionName, true, transportService, request, actionFilters);
@@ -49,13 +53,21 @@ protected HandledTransportAction(String actionName, TransportService transportSe
         this(actionName, true, transportService, actionFilters, requestReader, executor);
     }
 
+    /**
+     * @deprecated Use {@link #HandledTransportAction(String, boolean, TransportService, ActionFilters, Writeable.Reader)} instead.
+     */
+    @Deprecated
     protected HandledTransportAction(String actionName, boolean canTripCircuitBreaker,
                                      TransportService transportService, Supplier<Request> request, ActionFilters actionFilters) {
         super(actionName, actionFilters, transportService.getTaskManager());
         transportService.registerRequestHandler(actionName, request, ThreadPool.Names.SAME, false, canTripCircuitBreaker,
             new TransportHandler());
     }
 
+    /**
+     * @deprecated Use {@link #HandledTransportAction(String, boolean, TransportService, ActionFilters, Writeable.Reader, String)} instead.
+     */
+    @Deprecated
     protected HandledTransportAction(String actionName, TransportService transportService, Supplier<Request> request,
                                      ActionFilters actionFilters, String executor) {
         super(actionName, actionFilters, transportService.getTaskManager());