Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Darwin build without Cgo #182

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Fix Darwin build without Cgo #182

merged 1 commit into from
Nov 1, 2020

Conversation

tie
Copy link
Contributor

@tie tie commented Aug 15, 2019

Either cross-compiling or explicit CGO_ENABLED=0:

GOOS=darwin go build

Expected output: builds without an error
Actual output:

# github.com/rjeczalik/notify
./watcher_fsevents.go:49:11: undefined: stream

This PR addresses this issue by adding a fallback to kqueue on darwin,!cgo and enabling fsevents only for darwin,!kqueue,cgo.

@dvaldivia
Copy link

This looks great, when can this get merged?

@rjeczalik rjeczalik merged commit a684240 into rjeczalik:master Nov 1, 2020
@rjeczalik
Copy link
Owner

Thanks @tie for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants