Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of ckconv.nn APIs + demo notebook for Arxiv paper #2

Merged
merged 9 commits into from
Dec 7, 2021
Merged

Conversation

rjbruin
Copy link
Owner

@rjbruin rjbruin commented Dec 7, 2021

Major changes

  • APIs of CKConv and FlexConv now take parameters (instead of ConfigDicts) and have default values, for ease of use.
  • Added demo notebooks, to showcase usage of FlexConv.
  • Added testcases: use testcase.save & testcase.load to save/load a string of training losses to/from file, as a fingerprint for the training run. When loading, if the fingerprint doesn't match, the testcase raises an AssertionError. We use this to verify that any changed code does not change the training behavior.
    • Specifically, I implemented and used this to verify that the other listed changes do not affect the reproducibility of the paper's experiments with this codebase.

Minor changes

  • regularize_gabornet()s arguments were trimmed.

@rjbruin rjbruin requested a review from dwromero December 7, 2021 14:08
@rjbruin rjbruin self-assigned this Dec 7, 2021
@rjbruin
Copy link
Owner Author

rjbruin commented Dec 7, 2021

David let me know he doesn't have time to review, but trusts me. :)

@rjbruin rjbruin merged commit 3a6c0bb into master Dec 7, 2021
@rjbruin rjbruin deleted the demo branch December 7, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant