- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM replaces Manual #4
Conversation
Overall it's a very good approach, I like it. Will check more thoroughly soon |
Please add SPDX with license and your copyright as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three more things:
- Please check with
reuse lint
if all files are SPDX-ed properly - For files that aren't sources, you can use
.reuse/dep5
as in Rizin https://github.com/rizinorg/rizin/blob/dev/.reuse/dep5 - Please copy
.clang-format
from Rizin repo and check if C files are formatted properly https://github.com/rizinorg/rizin/blob/dev/.clang-format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good enough. But having able to operate without UTF-8 is crucial before merging and synchronizing it in Rizin.
Just recognized that two tests fail and I do not know why, yet.
Will make another push today or maybe next week.
Thank you for the feedback so far!
Jul 16, 2021 07:50:04 Anton Kochkov ***@***.***>:
… ***@***.**** approved this pull request.
It's good enough. But having able to operate without UTF-8 is crucial before merging and synchronizing it in Rizin.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub[#4 (review)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AK5ET6EH3PUNP2XW2TC2S73TX7CAVANCNFSM5AEE4Y4A]. [data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAADUAAAA1CAYAAADh5qNwAAAAAXNSR0IArs4c6QAAAARzQklUCAgICHwIZIgAAAAiSURBVGiB7cEBDQAAAMKg909tDjegAAAAAAAAAAAAAIB7AywZAAGURgP6AAAAAElFTkSuQmCC###24x24:true###][Tracking image][https://github.com/notifications/beacon/AK5ET6EY6F7UKO62755CN5DTX7CAVA5CNFSM5AEE4Y4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFIZ2F7Y.gif]
|
Hi,
so this is basically a complete rewrite of the generation code. I used LLVM as the source of information and no longer the Programmers Reference Manual. The reason is mainly that the parsing had to be done for each Manual again. This was error prone and could not be tested easily (and there are a lot more reasons).
There are still some non functional things missing in this version (list below), but I won't have that much time in the next two weeks to work on it further, so I just wanted to put it out for you to review.
I am very happy about any remarks, requests or improvement ideas!
Also I really hope the code is easy to understand, maintainable and extendable. If you have any remarks in this regard, please let me know as well!
Features comparison
##
. Non 32bit with#
TODO
No UTF-8 free assembly code at the moment (Instr. packets are prefixed with Unicode chars).-> UTF-8 chars are removed.handwritten
and then moved.rizin
instruction types for suitable instructions inhexagon_analyses.c
. Not just jmp instructions.