Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for HVX disassembly #8

Closed
Rot127 opened this issue Aug 3, 2021 · 1 comment
Closed

Add tests for HVX disassembly #8

Rot127 opened this issue Aug 3, 2021 · 1 comment
Labels
prioritize Increases the qualitiy significantly

Comments

@Rot127
Copy link
Member

Rot127 commented Aug 3, 2021

The disassembly of HVX instructions is not tested yet.

In order to solve this issue one has to:

  1. Add HVX instructions to handwritten/asm-tests/test-code.S which cover all kind of HVX operands (single, double, quartile registers, immediate values).
  2. Compile them with the Hexagon SDK, disassemble the binary with the SDKs objdump and compare the disassembly with the one rizin returns.
  3. If successful, add the tests here: handwritten/asm-tests/hexagon

Note that the most recent public Hexagon SDK version only supports v62 instructions and previous ones.
But our instruction set also includes instructions until v68.
It would be great if someone finds a way to test those as well.

@Rot127 Rot127 added the prioritize Increases the qualitiy significantly label Aug 3, 2021
@Rot127 Rot127 pinned this issue Aug 3, 2021
@Rot127
Copy link
Member Author

Rot127 commented Sep 29, 2021

Tracked by #27

@Rot127 Rot127 closed this as completed Sep 29, 2021
@Rot127 Rot127 mentioned this issue Sep 29, 2021
4 tasks
@Rot127 Rot127 unpinned this issue Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prioritize Increases the qualitiy significantly
Projects
None yet
Development

No branches or pull requests

1 participant