Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump capstone to 1995ddf9 #3621

Closed
wants to merge 1 commit into from
Closed

Bump capstone to 1995ddf9 #3621

wants to merge 1 commit into from

Conversation

imbillow
Copy link
Contributor

@imbillow imbillow commented Jul 2, 2023

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

...

XVilka
XVilka approved these changes Jul 2, 2023
View reviewed changes
test/db/tools/rz
@@ -141,6 +141,7 @@ FILE==
CMDS=!rizin -R ""
EXPECT_ERR=<<EOF
EOF
BROKEN=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this got broken?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember because of the extra log line

@XVilka XVilka requested a review from Rot127 July 2, 2023 03:41
@wargio wargio changed the title Update cs Bump capstone to 1995ddf9 Jul 2, 2023
XVilka
XVilka requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's probably better to merge Tricore capstone changes into one commit (to override old syntax changes) in the capstone-ng directly, also rebase the branch itself. Feel free to do that directly. Please also use the latest available capstone next commit: https://github.com/capstone-engine/capstone/commits/next

@XVilka XVilka mentioned this pull request Jul 4, 2023
Closed
5 tasks
@imbillow imbillow closed this Jul 4, 2023
@imbillow
Copy link
Contributor Author

imbillow commented Jul 4, 2023

I think it's probably better to merge Tricore capstone changes into one commit (to override old syntax changes) in the capstone-ng directly, also rebase the branch itself. Feel free to do that directly. Please also use the latest available capstone next commit: https://github.com/capstone-engine/capstone/commits/next

done

@XVilka XVilka deleted the capstone-ng-intel-syntax branch July 17, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka requested changes

@Rot127 Rot127 Rot127 approved these changes

@wargio wargio wargio approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r

@ret2libc ret2libc Awaiting requested review from ret2libc

Assignees
No one assigned
Labels
rz-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imbillow @XVilka @wargio @Rot127