Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qmake #2546

Merged
merged 6 commits into from
Jan 10, 2021
Merged

Remove qmake #2546

merged 6 commits into from
Jan 10, 2021

Conversation

karliss
Copy link
Member

@karliss karliss commented Jan 2, 2021

Your checklist for this pull request

Detailed description

  • Remove qmake build script
  • Define values that were previosuly read from qmake project directly in cmake project
  • Remove meson. It was also reading values from qmake project. Previously it was tested only on windows and for a while on no other platforms.
  • Update documentation

Test plan (required)

  • Nothing in CI is broken

Closing issues

Closes #2545

@XVilka
Copy link
Member

XVilka commented Jan 6, 2021

Probably worth also to remove .travis.yml.disabled too. We might instead add the test builds for the ARM64, PPC, SystemZ instead but later, once Rizin is all green on all of these.

https://github.com/rizinorg/rizin/blob/dev/.travis.yml

@XVilka XVilka requested a review from ret2libc January 6, 2021 04:41
@karliss karliss marked this pull request as ready for review January 6, 2021 21:50
set(CUTTER_VERSION_PATCH "${CUTTER_PRO_CUTTER_VERSION_PATCH}")
set(CUTTER_VERSION_MAJOR 1)
set(CUTTER_VERSION_MINOR 12)
set(CUTTER_VERSION_PATCH 0)

set(CUTTER_VERSION_FULL "${CUTTER_VERSION_MAJOR}.${CUTTER_VERSION_MINOR}.${CUTTER_VERSION_PATCH}")
Copy link
Member

@xarkes xarkes Jan 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really useful to have CUTTER_VERSION_FULL as it can be reconstructed with the other defines?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well whatever, doesn't matter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I consider it useful to have one place doing the gluing together instead of having 5 places copy pasting the same expression all over the place unless they have very specific needs.

Slightly related but offtopic for this PR is that in the versioning we should better distinguish between proper release versions and local or CI devbuilds. Both in package names and displayed version strings. At that point we might have additional suffix like "rc-n" or "-git-hash" in VERSION_FULL although some places need only the number part.

@karliss karliss merged commit 562979b into rizinorg:master Jan 10, 2021
@karliss karliss mentioned this pull request Oct 13, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish qmake removal
3 participants