-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove qmake #2546
Remove qmake #2546
Conversation
Probably worth also to remove https://github.com/rizinorg/rizin/blob/dev/.travis.yml |
set(CUTTER_VERSION_PATCH "${CUTTER_PRO_CUTTER_VERSION_PATCH}") | ||
set(CUTTER_VERSION_MAJOR 1) | ||
set(CUTTER_VERSION_MINOR 12) | ||
set(CUTTER_VERSION_PATCH 0) | ||
|
||
set(CUTTER_VERSION_FULL "${CUTTER_VERSION_MAJOR}.${CUTTER_VERSION_MINOR}.${CUTTER_VERSION_PATCH}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really useful to have CUTTER_VERSION_FULL
as it can be reconstructed with the other defines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well whatever, doesn't matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I consider it useful to have one place doing the gluing together instead of having 5 places copy pasting the same expression all over the place unless they have very specific needs.
Slightly related but offtopic for this PR is that in the versioning we should better distinguish between proper release versions and local or CI devbuilds. Both in package names and displayed version strings. At that point we might have additional suffix like "rc-n" or "-git-hash" in VERSION_FULL
although some places need only the number part.
Your checklist for this pull request
Detailed description
Test plan (required)
Closing issues
Closes #2545