CATALOG OF MY THINGS - CAPSTONE RUBY PROJECT #33

rivasbolinga · 2023-08-10T14:43:10Z

CATALOG OF MY THINGS - CAPSTONE RUBY PROJECT

Dear Code Reviewer 👋🏼,
We are please to inform you than my Coding Partners @mohametalmeari, @momo-87 and I have finished the Capstone Project for Ruby module - Catalog of my things.
Here there is a little summary of our work:

General requirements

No linter errors. ✅ ✅ ✅
Correct use Gitflow. ✅ ✅ ✅
Documented in a professional way. ✅ ✅ ✅
Project divided between tasks and review it between us ✅ ✅ ✅

Ruby requirements

Follow best practices for Ruby. ✅ ✅ ✅

Project requirements

User interface where the user can choose among the following options:

All the data is stored in json files.
All the data is stored in a database.
All the classes are tested with rspec.

Student A: @momo-87
Student B: @mohametalmeari
Student C: @rivasbolinga

Below you can find the video demostration:

📍 https://drive.google.com/file/d/1c0XJ-86VcacXnDZTQ67CyTB1Hj5Rl6rV/view?usp=sharing

**If you have any question don't hesitate to ask any of us by Slack and Zoom

Setup Project

…te .rb file)

…s less than 2 years ago

Group task

…ating a new music album

Update SQL code

Create Schemas File

#3 Team Member - Games preserve data

#3 Team Member - Game schema.sql

cynthiainga

Hi @rivasbolinga, @momo-87 & @mohametalmeari,

Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Highlights

No linters errors ✔️
All tests are passing ✔️
Correct Gitflow and GitHub flow ✔️
Data are preserved ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

mohametalmeari and others added 30 commits August 7, 2023 02:40

Install linters

5256de2

Update the README.md file

53db4df

Merge pull request #20 from rivasbolinga/setup

36fb818

Setup Project

Create Item class

c4f9e1c

Create one-to-many relationships

ca0d765

Fix linter errors

597601d

Implement move_to_archive and can_be_archived methods

357f5e4

Create setter methods

0fe58a2

Fix linter errors

7b6fc26

Create main.rb file and a method called main that creates a new App.new

d29c25d

Create Genre class with an association to the Item class (in a separa…

52cc451

…te .rb file)

Create ui class

3b6e829

Create apply method with all the cases

ede0481

Fix linters and run tests

29dacb1

Fix linter

70bb4a2

Implement can_be_archived?()method in the MusicAlbum class

4a50a56

Create Game class that is a child of Item

80a0481

Create can_be_archived method that returns true if the last played wa…

d9fe101

…s less than 2 years ago

Add attr accessors for Game class and create Author class

827e9e7

Create add_item method

b1b766a

Fix linters

5ef5e2f

Generate item id as a random number

f2f568f

Merge pull request #21 from rivasbolinga/group-task

ad0f9d3

Group task

Create Book class

f4009dc

Create Label class

f7a69ff

Implement list books and list labels methods

969876c

Implement create book method

6254556

Save books list on exit

860e25e

Open saved books

b2530a5

Fix linter errors

7922c82

rivasbolinga and others added 25 commits August 9, 2023 10:30

Store authors data

a222599

Remove create a genre from the options list and implement it when cre…

b1dbd3a

…ating a new music album

Fix linter errors

783742d

Add some minor changes for mergin purpose

786994d

Add some minors changes for mergin purpose

3399678

Add some minor changes for mergin purpose

b94efaa

Fix merging conflict

971cd5a

Fix bugs after mergin

8d08ff7

Fix linter errors

63854fd

Update SQL code to connect book table with itmes table

153c40e

Remove unnecessary lines

a7bd644

Merge pull request #31 from rivasbolinga/book-label

5c434d2

Update SQL code

Finish creating, listing and test

d5e80a8

Fix bug

3794073

Implement SQL code for move_to_archive and can_be_archived? methods

3e9b4c6

Merge pull request #28 from rivasbolinga/create-schemas-file

d82c6fa

Create Schemas File

Add items when created a new author

af121d2

Add message at the end

989bd3c

Merge pull request #29 from rivasbolinga/games-preserve-data

ea7da09

#3 Team Member - Games preserve data

Add tables

728206f

update Game to archived

f485548

Merge pull request #32 from rivasbolinga/game-schemasql

a7e771c

#3 Team Member - Game schema.sql

Update README and MIT files

f8a8a18

Update Schema.sql

12cd76d

Update README.md

bb1dc4c

rivasbolinga assigned rivasbolinga, momo-87 and mohametalmeari Aug 10, 2023

cynthiainga approved these changes Aug 10, 2023

View reviewed changes

rivasbolinga merged commit 224dec1 into main Aug 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CATALOG OF MY THINGS - CAPSTONE RUBY PROJECT #33

CATALOG OF MY THINGS - CAPSTONE RUBY PROJECT #33

rivasbolinga commented Aug 10, 2023 •

edited

Loading

cynthiainga left a comment •

edited by rivasbolinga

Loading

CATALOG OF MY THINGS - CAPSTONE RUBY PROJECT #33

CATALOG OF MY THINGS - CAPSTONE RUBY PROJECT #33

Conversation

rivasbolinga commented Aug 10, 2023 • edited Loading

CATALOG OF MY THINGS - CAPSTONE RUBY PROJECT

General requirements

Ruby requirements

Project requirements

cynthiainga left a comment • edited by rivasbolinga Loading

Choose a reason for hiding this comment

Highlights

Optional suggestions

rivasbolinga commented Aug 10, 2023 •

edited

Loading

cynthiainga left a comment •

edited by rivasbolinga

Loading