Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests for changes on master branch #2444

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

christian-bromann
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

The tests introduced in #2400 are currently not triggered because the main branch is called master. I recommend to rename the default branch to main and close this PR or if there are reasons not to change the main branch merge this one so that tests are triggered correctly.

[x] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other: <!-- Please describe: -->

What is the current behavior?

No tests are triggered.

What is the new behavior?

Tests are being triggered.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ritwickdey ritwickdey merged commit ac31be3 into ritwickdey:master Aug 30, 2022
@ritwickdey
Copy link
Owner

Hey, there is some issue with macOS and Windows.

I've tried in my local (Mac-M1), the test suite is crashing.

Github Job (failing randomly): https://github.com/ritwickdey/vscode-live-server/actions/runs/2953216184/attempts/4

My local:

2022-08-30T02:38:03.860Z ERROR webdriver: Request failed with status 500 due to unknown error: unknown error: Chrome failed to start: exited abnormally.
[0-0]   (unknown error: DevToolsActivePort file doesn't exist)
The process started from chrome location /wdio-vscode-service/dist/chromium/index.js is no longer running, so ChromeDriver is assuming that Chrome has crashed.

@christian-bromann
Copy link
Contributor Author

Let me take a look 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants