Fix(#88): Adding an option for use local IP as host #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritwickdey
requested changes
May 6, 2018
src/Helper.ts
Outdated
|
|
||
| public static getEthernetInfo() { | ||
| var interfaces = os.networkInterfaces(); | ||
| return interfaces['Ethernet'][1]; |
There was a problem hiding this comment.
interfaces['Ethernet'] I think, it depends on adapter name & varies device to device.. Right?
one reference : https://stackoverflow.com/a/49205710/6120338
There was a problem hiding this comment.
Actually you are right. Thanks for the link.
src/Helper.ts
Outdated
| @@ -150,5 +151,8 @@ export class Helper { | |||
| return proxy; | |||
| } | |||
|
|
|||
|
|
|||
| public static getEthernetInfo() { | |||
| var interfaces = os.networkInterfaces(); | |||
There was a problem hiding this comment.
I forgot that this is typescript. I am fixing this soon
|
Thank you sooooo much for the PR 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Ethernet address along with configuration. I have prepared this PR for #88 but without using
node-ip.