Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

Added ability to disable map files as a setting #9

Merged
merged 2 commits into from
Aug 25, 2017

Conversation

mhco
Copy link
Contributor

@mhco mhco commented Aug 24, 2017

This change allows users to specify in the settings whether they want to generate map files for the given project. This can be changed with the following setting variable: liveSassCompile.settings.generateMap.

This change allows users to specify in the settings whether they want to generate map files for the given project. This can be changed with the following setting variable: liveSassCompile.settings.generateMap.
@mhco
Copy link
Contributor Author

mhco commented Aug 24, 2017

If the user doesn't have the setting defined, or if the user defines the setting as, "true," then the script will compile the map file as usual; only if the user has the setting defined, AND it is defined as, "false," will it omit the map file entirely. This works with watched and unwatched files.

Further testing may need to be done on this update.

Added the "generateMap" setting to the list of configurations. Possible options include true or false, with true being the default (so as to not disrupt anybody's current usage of this extension).
@ritwickdey
Copy link
Owner

Thanks a lotttttt for the contribution 😄 😃 ....

I've one question, why you wrote helper_1.Helper. not just Helper. ? is that working?

@mhco
Copy link
Contributor Author

mhco commented Aug 25, 2017

@ritwickdey that was actually just something that came along when I copied that line from earlier in the file. Honestly, I don't think it's necessary to include the "helper_1" part, but it worked, so I didn't think twice about it. Please feel free to remove that "helper_1" or modify the code in any way that works best; this is just a modification I made for myself that I wanted to share with others.

@ritwickdey ritwickdey merged commit 355288e into ritwickdey:master Aug 25, 2017
ritwickdey added a commit that referenced this pull request Aug 25, 2017
@ritwickdey
Copy link
Owner

hi, @mhco Thanks again 😃 . I've merged the PR with some necessary changes :)

ritwickdey added a commit that referenced this pull request Aug 25, 2017
ritwickdey added a commit that referenced this pull request Aug 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants