This repository has been archived by the owner on Mar 10, 2022. It is now read-only.
Autoprefix CSS properties #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…: -ms-flexbox`). Usage: Pass a [Browserlist](https://github.com/ai/browserslist) supported string (e. g. `last 2 versions`) to the `liveSassCompile.settings.autoprefix` config, or `null` to turn off. Default is `null`.
|
Wah!! Thanks a lot for the PR 😄 |
ritwickdey
reviewed
Oct 30, 2017
package.json
Outdated
| "type": [ | ||
| "string", | ||
| "null" | ||
| ], |
There was a problem hiding this comment.
Do you not think it could be an array ?
(I don't know much about the configuration of browerlist).
I got this from https://github.com/ai/browserslist
"browserslist": [
"> 1%",
"last 2 versions"
]
There was a problem hiding this comment.
Might be better as an array, yes! I'll fix it as soon as possible.
|
I test locally, It's working perfectly fine... Thanks a lot 😄 |
ritwickdey
reviewed
Oct 30, 2017
src/appModel.ts
Outdated
| */ | ||
| private async autoprefix(css: string, target: string): Promise<string> { | ||
| let result = ''; | ||
|
|
There was a problem hiding this comment.
But target & result is not used anywhere.
There was a problem hiding this comment.
what have I been doing
Thanks for reviewing!
|
Looks great 😃 ... Thanks (again) for the PR! ❤️ |
|
Glad to help! 😺 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage
Pass a Browserlist supported string (e. g.
last 2 versions) to theliveSassCompile.settings.autoprefixconfig, ornullto turn off. Default isnull.Solves #19