70 automatically signin user who creates signin #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Kudos for Multiple Users
|
I will look closer when I get home. But looks like you did not change existing interaction response, so it will |
|
Yeah, I am aware of that. Was going to communicate with you about that, just confused about it. |
1nv8rzim
reviewed
Dec 24, 2023
commands/slash/signin.go
Outdated
Comment on lines
180
to
190
| err = s.InteractionRespond(i.Interaction, &discordgo.InteractionResponse{ | ||
| Type: discordgo.InteractionResponseChannelMessageWithSource, | ||
| Data: &discordgo.InteractionResponseData{ | ||
| Content: signinMessage(i.Member.User.ID, entSigninType, span.Context()), | ||
| Flags: discordgo.MessageFlagsEphemeral, | ||
| }, | ||
| }) | ||
| if err != nil { | ||
| logging.Error(s, err.Error(), i.Member.User, span, logrus.Fields{"error": err}) | ||
| return | ||
| } |
There was a problem hiding this comment.
Message is sent to command user here
There was a problem hiding this comment.
There was a problem hiding this comment.
These both use the same interaction; best way to do this is just combine this into the later one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change user to be the person executing command, should be something like i.Member.User.ID
change span context to match execution block (use span instead of span_signinSlug)