Staging #69
Merged
Staging #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ent Schema
Data abstraction
birthday abstractions
Slash command
Scheduled event
Sophduke patch 1
Birthday Feature
Patch to Birthday Command
Closed
jabbate19
suggested changes
Dec 7, 2023
Comment on lines
+75
to
+88
| entRemoveBirthdays, err := data.Birthday.GetBirthdays(yesterday.Day(), int(yesterday.Month()), internalSpan.Context()) | ||
| if err != nil { | ||
| logging.Error(s, "failed to get yesterday's birthdays", nil, span, logrus.Fields{"error": err}) | ||
| return | ||
| } | ||
|
|
||
| // Remove yesterday's birthdays | ||
| for _, entRemoveBirthday := range entRemoveBirthdays { | ||
| err = removeBirthday(s, entRemoveBirthday.Edges.User.ID, internalSpan.Context()) | ||
| if err != nil { | ||
| logging.Error(s, "failed to remove birthday for "+helpers.AtUser(entRemoveBirthday.Edges.User.ID), nil, span, logrus.Fields{"error": err}) | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
Edge/Exploit Case: I move my birthday on my birthday. I wouldn't come up here
There was a problem hiding this comment.
This is the scheduled task that adds and removes birthdays at midnight.
This edge case is covered in the snippets commented below
1nv8rzim
commented
Dec 7, 2023
Comment on lines
+246
to
+262
| now := time.Now().In(tz) | ||
| if month == int(now.Month()) && day == int(now.Day()) { | ||
| // respond to user that birthday cannot be today | ||
|
|
||
| err := s.InteractionRespond(i.Interaction, &discordgo.InteractionResponse{ | ||
| Type: discordgo.InteractionResponseChannelMessageWithSource, | ||
| Data: &discordgo.InteractionResponseData{ | ||
| Content: "You cannot set your birthday to be today", | ||
| Flags: discordgo.MessageFlagsEphemeral, | ||
| }, | ||
| }) | ||
| if err != nil { | ||
| logging.Error(s, "encounted error when responding to user", i.Member.User, span, logrus.Fields{"err": err.Error()}) | ||
| } | ||
|
|
||
| return | ||
| } |
There was a problem hiding this comment.
Birthday Edit or Add on Birthday Edge Case
1nv8rzim
commented
Dec 7, 2023
Comment on lines
+152
to
+168
| now := time.Now().In(tx) | ||
| if int(entBirthday.Month) == int(now.Month()) && int(entBirthday.Day) == int(now.Day()) { | ||
| // respond to user that birthday cannot be today | ||
|
|
||
| err := s.InteractionRespond(i.Interaction, &discordgo.InteractionResponse{ | ||
| Type: discordgo.InteractionResponseChannelMessageWithSource, | ||
| Data: &discordgo.InteractionResponseData{ | ||
| Content: "You cannot remove your birthday today", | ||
| Flags: discordgo.MessageFlagsEphemeral, | ||
| }, | ||
| }) | ||
| if err != nil { | ||
| logging.Error(s, "encounted error when responding to user", i.Member.User, span, logrus.Fields{"err": err.Error()}) | ||
| } | ||
|
|
||
| return | ||
| } |
There was a problem hiding this comment.
Birthday Delete on Birthday Edge Case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.