Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the user's username next to the userID in the query #95 #103

Merged
merged 10 commits into from
Apr 26, 2024
Merged

Conversation

c0untingNumbers
Copy link
Contributor

Treasurer requested for an option of a csv file of usernames

closes #95
#95

1nv8rzim and others added 10 commits January 11, 2024 13:36
Update Staging after Dependabot Updates
Bring staging up to main
…-the-userid-in-the-query

added usernameinFileOnly option
…o-the-userid-in-the-query

removed camelcase on option name because discord hates it
…o-the-userid-in-the-query

replaced camel cased names
…o-the-userid-in-the-query

moved the interactionrespond and fixed output formatting
@c0untingNumbers c0untingNumbers requested a review from a team as a code owner April 26, 2024 05:42
@1nv8rzim
Copy link
Member

Names used to be part of this, but Discord does ratelimiting with exponential backoff for resolving usernames via the api meaning that this query will take forever, for anything larger than like 10/20 people iirc

@c0untingNumbers
Copy link
Contributor Author

This option is mostly going to be used by Treasurer. He's not going to use it too often.

I talked to the Treasurer about the query taking forever. He said he just needs it for receipts for competitions and meetings and I guess he doesn't mind waiting for it?

Copy link
Contributor

@voxelvortex voxelvortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voxelvortex voxelvortex merged commit d133eaa into main Apr 26, 2024
4 checks passed
@1nv8rzim
Copy link
Member

I might have not been clear before when I said query will take forever, I didn't mean like a couple minutes, I mean like long enough that discord will not be able to access the interaction anymore and just not be able to send the results.

@c0untingNumbers
Copy link
Contributor Author

Okay, not updating the main OBIII until I add some what of a delay for each call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have the user's username next to the userID in the query
3 participants