Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce feature helper modules visibility to pub(super) #5

Merged
merged 2 commits into from
Jul 30, 2022

Conversation

nayyara-airlangga
Copy link
Collaborator

I reduced the visibility for modules which are not the feature modules for the library. I call these helper modules as they help in separating internal code within a feature for increased readability. This will also help reduce noise in the docs.rs as now only the necessary components of a feature module are exposed to the documentation.

I reduced it to pub(super) instead of pub(crate) because if features need to integrate with each other, we can use the re-exports from the feature module instead of the feature helper modules.

@nayyara-airlangga nayyara-airlangga added the enhancement New feature or request label Jul 30, 2022
@nayyara-airlangga nayyara-airlangga self-assigned this Jul 30, 2022
@nayyara-airlangga nayyara-airlangga merged commit 8d10e9f into main Jul 30, 2022
@nayyara-airlangga nayyara-airlangga deleted the reduce-helper-module-visibility branch July 30, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant