Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ticket validation request to be synchronous #16

Merged
merged 5 commits into from
Aug 1, 2022

Conversation

nayyara-airlangga
Copy link
Collaborator

I discovered an http client called http_req and it provides the ability to make synchronous requests. This is enough for our project and works great with the existing code.

This will also give us the ability to remove heavy and asynchronous dependencies such as tokio and reqwest from the project to make it slimmer.

@nayyara-airlangga nayyara-airlangga added the enhancement New feature or request label Aug 1, 2022
@nayyara-airlangga nayyara-airlangga self-assigned this Aug 1, 2022
@nayyara-airlangga nayyara-airlangga linked an issue Aug 1, 2022 that may be closed by this pull request
@nayyara-airlangga nayyara-airlangga merged commit 59799c9 into main Aug 1, 2022
@nayyara-airlangga nayyara-airlangga deleted the cut-dependencies branch August 1, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the ticket validation synchronous
1 participant