Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate project URL into two categories #1

Open
wutsqo opened this issue Oct 17, 2021 · 3 comments
Open

Separate project URL into two categories #1

wutsqo opened this issue Oct 17, 2021 · 3 comments

Comments

@wutsqo
Copy link

wutsqo commented Oct 17, 2021

Currently, each project item at the src/utils/data/Projects.json file contains a "url" key. Some of the values are the URL to the repository, while others are the URL to the product's webpage.

I think it is a good idea to split them into two categories: "homepage_url" and "repository_url".

It'll open some new possibilities for the future development of this site. One example is to display the repo status (forks, stars, contributors, topic, etc.) directly on the project card using GitHub API. Another example is that the visitors can choose whether they want to visit the site or just the repo.

Wdyt, maintainers?

@jonathanfilbert
Copy link
Member

jonathanfilbert commented Oct 22, 2021

Hey Wutsqo. Great idea! But one thing to consider is, there are several products that don't have homepage _url. Products such as CLIs or libraries typically only have 1 link directing to their repository URL. So if say, we go with your suggestion, how would we fill the homepage_url for those kind of products?

@wutsqo
Copy link
Author

wutsqo commented Oct 22, 2021

I think we can just make it optional, like project?.homepage_url. Not sure if thats a good idea haha

@jonathanfilbert
Copy link
Member

That could work! Do a pull request and I’ll review when you’re ready. 👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants