Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: regenerate & format slt tests #6776

Merged
merged 5 commits into from
Dec 7, 2022
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Dec 6, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Corresponds to risinglightdb/sqllogictest-rs#112. Note that I only regenerate the tests without bumping sqllogictest yet, so if ci passed it should be considered harmless. 🤪

Main change:

  • If there's rowsort, slt file will contain sorted results.

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #6776 (b224a77) into main (4380c61) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #6776   +/-   ##
=======================================
  Coverage   73.21%   73.21%           
=======================================
  Files        1024     1024           
  Lines      163802   163802           
=======================================
+ Hits       119928   119929    +1     
+ Misses      43874    43873    -1     
Flag Coverage Δ
rust 73.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/scheduler/hummock_snapshot_manager.rs 58.79% <0.00%> (+0.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xxchan xxchan marked this pull request as ready for review December 7, 2022 14:56
@TennyZhuang TennyZhuang merged commit f4abbcd into main Dec 7, 2022
@TennyZhuang TennyZhuang deleted the xxchan/chosen-canidae branch December 7, 2022 17:03
xxchan added a commit that referenced this pull request Dec 10, 2022
TennyZhuang pushed a commit that referenced this pull request Dec 11, 2022
* Revert "chore: regenerate & format slt tests (#6776)"

This reverts commit f4abbcd.

* rerun sqllogictest --override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants