refactor(source): remove drop_source rpc in CN #5849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5849 +/- ##
==========================================
- Coverage 75.09% 74.85% -0.25%
==========================================
Files 920 922 +2
Lines 145144 146824 +1680
==========================================
+ Hits 108996 109900 +904
- Misses 36148 36924 +776
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yezizp2012
reviewed
Oct 14, 2022
Co-authored-by: August <[email protected]>
Co-authored-by: August <[email protected]>
BugenZhao
reviewed
Oct 14, 2022
BugenZhao
reviewed
Oct 14, 2022
PanQL
force-pushed
the
panpan/remove_drop_source
branch
from
dadf001
to
50844c5
Compare
- remove TableSourceManager trait and use MemSourceManager directly. - remove useless source desc during insert_source instead.
PanQL
changed the title
|
@Mergifyio requeue |
☑️ This pull request is already queued |
PanQL
force-pushed
the
panpan/remove_drop_source
branch
from
dbaea4f
to
224f54e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
This pr remove drop_source rpc in CN, and remove useless SourceDesc when inserting new SourceDesc.
Checklist
./risedev check(or alias,./risedev c)Types of user-facing changes
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)